Skip to content

Conversation

eventualbuddha
Copy link
Collaborator

Maintenance LTS, Active LTS, and Current.

Maintenance LTS, Active LTS, and Current
@eventualbuddha eventualbuddha requested a review from Copilot July 11, 2025 20:22
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the GitHub Actions CI matrix to test newer Node.js versions aligning with maintenance LTS, active LTS, and current releases.

  • Replace tests on Node 16.x and 18.x with 20.x, 22.x, and 24.x
  • Ensure CI covers the intended lifecycle stages of Node.js
Comments suppressed due to low confidence (1)

.github/workflows/ci.yml:11

  • The updated Node.js matrix omits the maintenance LTS version (18.x) mentioned in the description and includes 22.x, which is not an LTS. To match the goal of testing maintenance LTS, active LTS, and current, consider using [18.x, 20.x, 24.x] instead.
        node-version: [20.x, 22.x, 24.x]

@ItsHarper ItsHarper mentioned this pull request Aug 14, 2025
9 tasks
@ItsHarper
Copy link
Contributor

To elaborate on what I said about this PR in #927, CI is failing because of a new deprecation warning added to node 24 about the url.parse API (the warning gets printed to stderr, which a test checks is empty).

We could hack the test to disable checking stderr, but it would be much better just to not use the problematic URL parser. We're currently using cross-fetch/node-fetch, which is what is making the problematic call. Now that fetch is natively everywhere (including node), those libraries are unmaintained, so we need to switch to native fetch, not just update a library.

Like I said in #927, I did try to switch to native fetch without migrating to ESM, but I could not get that to work properly. The ESM migration will either fix it, or at least make the whole environment much easier to reason about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants