Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some examples #8

Merged
merged 1 commit into from
Jul 14, 2019
Merged

Add some examples #8

merged 1 commit into from
Jul 14, 2019

Conversation

Lunaticf
Copy link
Contributor

#3
Add some examples.
Not sure if it can meet the requirement as a beginner,just try to help.

Notice that some red log output appeared when I call those function, like create an address will print a array contains binary nums thought it is bad for examples so I removed those print statement。

Remove the .vscode directory. Cause I am using golang, so I add the “.idea” in .gitignore.

PS: I dont’ know the convention of golang file name, so I follow your name rule, but it looks bad to me to not use the camel case or the snake case.

Thanks!

@codemaveric
Copy link
Owner

Hi @Lunaticf,

Thanks for your contribution!!!! Bonus point on removing .vscode, you can take it a step further by adding it to .gitignore, I should have added it to .gitignore from day one.

I'm sure it will get us in the right direction and any help at all is welcome!. Once I review it I will let you know if anything needs to be adjusted.

Thanks again for your contribution.

@codemaveric codemaveric merged commit 1addf1c into codemaveric:master Jul 14, 2019
@codemaveric
Copy link
Owner

Hi @Lunaticf,

I have reviewed and approve the PR. The examples were neat and straight forward.

Currently working on Transactions History and Get Transaction Details by Sequence. I will let you know once I'm done if you will be kind enough to also write examples for it :).

Thanks so much for your contribution. Hope to see more PR from you.

@Lunaticf
Copy link
Contributor Author

@codemaveric
Thanks,This is encouragement to me. Will continue to contribute,hope to help more than examples.

@codemaveric
Copy link
Owner

You're welcome @Lunaticf

Yeah, there are other things you can contribute aside examples.

List of things in my pipeline

  1. Get Transaction History
  2. Get Transaction Details with Seq No
  3. Test - It's bad that we don't have any test at all
  4. Code Documentation using GoDoc

I'm already working on 1 and 2. It will be nice if you can pick either the testing or documentation. If you have anything else you feel we should implement, lemme know and we can decide to add it.

Regards

@Lunaticf
Copy link
Contributor Author

@codemaveric ok, I will implement some stuff in my spare time and check what else we can do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants