Handle altool failures with returncode 0

[priitlatt]

The problem

This pull request addresses an issue where the app-store-connect publish command could incorrectly report a successful completion despite the App Store Connect publishing action failing.

A recent version of the altool (bundled with Xcode 26), exhibits unreliable behavior: it may return a successful exit code (0) even when the submission or publishing action has failed on the App Store Connect side. See also PR #476.

This behavior bypasses our existing error handling, leading to an issue where a successful publishing is reported although publishing actually had failed.

Fix

To improve error reporting this PR implements a new error detection mechanism:

• We no longer rely solely on the altool return code.
• Publishing status is now determined by parsing the command output for specific failure indicators and result structures.

The changes proposed here include crucial updates to handle output from recent altool versions:

• The logic for detecting the final result has been revised to match the latest formatting changes introduced in recent altool versions.
• We now correctly detect and process the result JSON structure even when it spans multiple lines in the command output.

Updated actions

• app-store-connect publish

[fran-tirapu]

I am not sure about the need of this regex.
It seems like json.loads and AltoolResult.create are enough validation. do you add it just as a quick check to improve performance or are there any hidden thing I am not seeing?

[priitlatt]

This is a good point. json.loads will do validation on its own anyway, rendering the regex check useless.
And running some benchmarks revealed that with "good" cases where the JSON result is right in the end of the log there is no speedup, however in case of a big enough log (~2000 lines) which contains no valid result, then there is a slowdown when using regex check.

[priitlatt]

Updated in 52a9ec4.

[fran-tirapu]

🚀
Nice job adding mocks to test all possible scenarios with legacy and current versions of the tool.