Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yohan11 is attempting to deploy a commit to the soohwan93's projects Team on Vercel. A member of the Team first needs to authorize it. |
arthurkimdev
approved these changes
May 3, 2024
Comment on lines
+48
to
+51
| {links && | ||
| links.map((link) => { | ||
| const createdAt = link.created_at || link.createdAt; | ||
| const imageSource = link.image_source || link.imageSource; |
There was a problem hiding this comment.
뭔가 Prettier, Lint 룰이 변경되었나보군요!
Comment on lines
+56
to
+69
| return ( | ||
| <Card | ||
| key={link.id} | ||
| id={link.id} | ||
| cardImage={imageSource} | ||
| cardTime={{ | ||
| createdDateString: formatDate(createdDate), | ||
| timeDifference: getTimeDifference(createdDate, currentDate), | ||
| }} | ||
| cardDescription={link.description || ""} | ||
| cardUrl={link.url} | ||
| /> | ||
| ); | ||
| })} |
There was a problem hiding this comment.
뭔가 Prettier, Lint 룰이 변경되었나보군요!
There was a problem hiding this comment.
들여쓰기 뎁스는 보통 실무에서 4보다는 2를 더 많이 사용하곤 합니다~
Comment on lines
-32
to
+48
| {foldersInfo.length !== 0 | ||
| {foldersInfo |
Comment on lines
+54
to
+56
| if (!context) { | ||
| throw new Error(""); | ||
| } |
There was a problem hiding this comment.
에러 메시지에 "" 보다는 아래처럼 조금 더 구체적인 메시지가 담기면 향후 디버깅에 보다 수월할거에요~
if (!context) {
throw new Error("MyInfoContext state error");
}
| hostname: "bootcamp-api.codeit.kr", | ||
| port: "", | ||
| pathname: "/api/**", //**는 해당 경로 뒤에 모든 경로, | ||
| hostname: "**", |
Comment on lines
+99
to
+102
| const loadFolders = async () => { | ||
| const res = await getFolders(); | ||
| setFoldersInfo(res); | ||
| }; |
There was a problem hiding this comment.
이 부분은 다른 곳에서도 사용되던데, 이런 경우 util로 분리해서 함께 사용해도 좋겠습니다.
Comment on lines
+3
to
5
| function Index() { | ||
| return <div>Index</div>; | ||
| } |
There was a problem hiding this comment.
페이지 컴포넌트명이 Index 보다는 Home 혹은 Main 이 보다 명시적일 것 같습니다~
Comment on lines
+64
to
+76
| // const loadNewLinks = () => { | ||
| // if (keyword) { | ||
| // const loweredKeyword = keyword.toLowerCase(); | ||
| // setLinks((prevState: TLink[]) => FILTER_LINKS(prevState, loweredKeyword)); | ||
| // } else { | ||
| // setLinks(folderInfo.links); | ||
| // } | ||
| // }; | ||
|
|
||
| // useEffect(() => { | ||
| // loadNewLinks(); | ||
| // }, [keyword]); | ||
|
|
| {keyword ? ( | ||
| <SearchMessage> | ||
| {keyword} | ||
| <span className="font-color-gray4">으로 검색한 결과입니다.</span> |
There was a problem hiding this comment.
font-color-gray4 css 클래스명이 구체적이라 좋습니다.
arthurkimdev
merged commit 804e55a
into
codeit-bootcamp-frontend:part3-김준영
0 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
리팩토링 예정
멘토에게