Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
arthurkimdev
approved these changes
May 3, 2024
Comment on lines
+1
to
+8
| export const safeGetItem = (key: string) => { | ||
| try { | ||
| return localStorage.getItem(key); | ||
| } catch (error) { | ||
| console.error(error); | ||
| return null; | ||
| } | ||
| }; |
There was a problem hiding this comment.
여기서 리턴값이 null로 되어있는 경우에는 키에 대한 값이 없어서 null 일때와 에러가 발생해서 받은 값인 null 경우 구분하기가 어렵기 때문에, 해당 키 값이 없을땐 null / 에러 발생 시 undefined 이렇게 구분해서 리턴해주면 좋습니다~
| }; | ||
|
|
||
| export const passwordTextInputProps = (inputType: string) => ({ | ||
| type: inputType, |
There was a problem hiding this comment.
여기서 inputType 값은 password 값이 일반적입니다~
| @@ -0,0 +1,17 @@ | |||
| export const emailTextInputProps = { | |||
| type: "text", | |||
There was a problem hiding this comment.
여기서 inputType 값은 email 값이 더 일반적입니다.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input
Comment on lines
+35
to
36
| const accessToken = safeGetItem("accessToken"); | ||
| if (accessToken !== null) setToken(accessToken); |
There was a problem hiding this comment.
지난번 리뷰 사항을 잘 반영해주셨네요 👍
arthurkimdev
reviewed
May 3, 2024
| @@ -32,7 +34,7 @@ function SigninForm() { | |||
| console.log(accessToken); | |||
|
|
|||
| if (accessToken) { | |||
| localStorage.setItem("accessToken", accessToken); | |||
| saveToLocalStorage("accessToken", accessToken); | |||
arthurkimdev
merged commit aa1f487
into
codeit-bootcamp-frontend:part3-황경수
1 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본