Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: primary key mapping in the model for the entity #9307

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

michalsn
Copy link
Member

@michalsn michalsn commented Dec 7, 2024

Description
This PR fixes a bug that caused the Model::getIdValue() to not correctly recognize the primary key in the Entity object if a data mapping for the primary key was used.

Fixes: #9306

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn added the bug Verified issues on the current code behavior or pull requests that will fix them label Dec 9, 2024
@kenjis kenjis added the database Issues or pull requests that affect the database layer label Dec 11, 2024
@michalsn michalsn merged commit 539436f into codeigniter4:develop Dec 11, 2024
42 checks passed
@michalsn
Copy link
Member Author

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Mapping Entity's primary key breaks Models save()
3 participants