Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix @param ResponseInterface::setJSON() also accepts objects #9287

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

JulianAtkins
Copy link
Contributor

@JulianAtkins JulianAtkins commented Nov 18, 2024

Description
The function setJSON also accepts objects, as is already implemented in the ResponseTrait.php (lines 166 to 178), thus use the same types (array|object|string) for the interface, only "object" was missing.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn changed the title fix: The function setJSON also accepts objects fix: ResponseInterface::setJSON() also accepts objects Nov 19, 2024
@paulbalandan paulbalandan merged commit 72f6a78 into codeigniter4:develop Nov 29, 2024
41 checks passed
@kenjis kenjis changed the title fix: ResponseInterface::setJSON() also accepts objects docs: fix @param ResponseInterface::setJSON() also accepts objects Dec 5, 2024
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants