Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [Validation] add support for $dbGroup as parameter in is_unique and is_not_unique #9216

Merged
merged 1 commit into from
Dec 1, 2024
Merged

feat: [Validation] add support for $dbGroup as parameter in is_unique and is_not_unique #9216

merged 1 commit into from
Dec 1, 2024

Conversation

maniaba
Copy link
Contributor

@maniaba maniaba commented Oct 6, 2024 •
edited by paulbalandan
Loading

Description

Fixes #9215

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr added the wrong branch PRs sent to wrong branch label Oct 7, 2024
@ddevsr
Copy link
Collaborator

ddevsr commented Oct 7, 2024

This is enchantment, send to branch 4.6

@maniaba maniaba changed the base branch from develop to 4.6 October 7, 2024 20:29
@maniaba
Copy link
Contributor Author

maniaba commented Oct 7, 2024

This is enchantment, send to branch 4.6

I’ve switched to branch 4.6, everything is now set. Could you please remove the 'wrong branch' label?

@ddevsr ddevsr added 4.6 enhancement PRs that improve existing functionalities and removed wrong branch PRs sent to wrong branch labels Oct 10, 2024
michalsn
michalsn reviewed Oct 11, 2024
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good.

user_guide_src/source/libraries/validation.rst Outdated Show resolved Hide resolved
@maniaba maniaba requested a review from michalsn October 21, 2024 16:45
michalsn
michalsn requested changes Oct 21, 2024
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last things from me.

user_guide_src/source/changelogs/v4.6.0.rst Outdated Show resolved Hide resolved
system/Validation/StrictRules/Rules.php Outdated Show resolved Hide resolved
ddevsr
ddevsr reviewed Oct 22, 2024
View reviewed changes
system/Validation/Rules.php Outdated Show resolved Hide resolved
@maniaba maniaba requested a review from michalsn November 13, 2024 08:38
@maniaba maniaba requested a review from michalsn November 14, 2024 07:12
michalsn
michalsn approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thank you.

@paulbalandan paulbalandan changed the title feat: [Validation] add support for dbGroup as parameter in is_unique and is_not_unique feat: [Validation] add support for $dbGroup as parameter in is_unique and is_not_unique Dec 1, 2024
@maniaba @paulbalandan
feat: Add optional dbGroup support in validation rules for multiple d…
86278d9 
…atabase connections

cs fixer

docs format

fix rules

add test testIsNotUniqueWithDBConnectionAsParameter

docs: update v4.5.6.rst

docs: fix tabs

docs update for v4.6.0

Update validation.rst

Update user_guide_src/source/changelogs/v4.6.0.rst

Co-authored-by: Michal Sniatala <[email protected]>

Add a test case for `InvalidArgumentException` and remove the duplicate comment.

refactor: code for is_unique and is_not_unique methods; extracted common code into prepareUniqueQuery method

rector and phpstan fix
@paulbalandan paulbalandan merged commit d6d30c0 into codeigniter4:4.6 Dec 1, 2024
45 checks passed
@paulbalandan
Copy link
Member

Thank you, @maniaba

@paulbalandan paulbalandan linked an issue Dec 1, 2024 that may be closed by this pull request
Dev: Enhancement add support for dbGroup in is_unique and is_not_unique validation rules #9215
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddevsr ddevsr ddevsr left review comments

@paulbalandan paulbalandan paulbalandan approved these changes

@michalsn michalsn michalsn approved these changes

@kenjis kenjis Awaiting requested review from kenjis

@samsonasik samsonasik Awaiting requested review from samsonasik

Assignees
No one assigned
Labels
4.6 enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dev: Enhancement add support for dbGroup in is_unique and is_not_unique validation rules
4 participants
@maniaba @ddevsr @paulbalandan @michalsn