fix failing jobs

codeigniter4 · Nov 18, 2024 · a186c0f · a186c0f
1 parent a9862ec
commit a186c0f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 10 deletions.
diff --git a/system/Files/File.php b/system/Files/File.php
@@ -73,7 +73,6 @@ public function getSize()
     /**
      * Retrieve the file size by unit, calculated in IEC standards with 1024 as base value.
      *
-     * @param FileSizeUnit $unit
      * @phpstan-param positive-int $precision
      * @return false|int|string
      */
@@ -85,7 +84,6 @@ public function getSizeByUnitBinary(FileSizeUnit $unit = FileSizeUnit::B, int $p
     /**
      * Retrieve the file size by unit, calculated in metric standards with 1000 as base value.
      *
-     * @param FileSizeUnit $unit
      * @phpstan-param positive-int $precision
      * @return false|int|string
      */
@@ -222,12 +220,10 @@ public function getDestination(string $destination, string $delimiter = '_', int
     protected function getSizeByUnitInternal(int $fileSizeBase, FileSizeUnit $unit, int $precision)
     {
         $exponent = $unit->value;
-        $divider = $fileSizeBase ** $exponent;
+        $divider  = $fileSizeBase ** $exponent;
+        $size     = $this->getSize() / $divider;
 
-        $size = $this->getSize() / $divider;
-
-        if($unit !== FileSizeUnit::B)
-        {
+        if($unit !== FileSizeUnit::B) {
             $size = number_format($size, $precision);
         }
 

diff --git a/system/Files/FileSizeUnit.php b/system/Files/FileSizeUnit.php
@@ -13,11 +13,11 @@
 
 namespace CodeIgniter\Files;
 
-enum FileSizeUnit : int
+enum FileSizeUnit: int
 {
     case B  = 0;
     case KB = 1;
     case MB = 2;
     case GB = 3;
     case TB = 4;
-}
+}
diff --git a/tests/system/Files/FileTest.php b/tests/system/Files/FileTest.php
@@ -170,7 +170,7 @@ public function testGetDestination(): void
     }
 
     /**
-     * @return array<string, list<int>>
+     * @return array<string, array<int, CodeIgniter\Files\FileSizeUnit>>
      */
     public static function provideGetSizeData()
     {
-Original file line number
+Diff line change
@@ Expand Up / @@ -170,7 +170,7 @@ public function testGetDestination(): void @@
         }
         /**
-         * @return array<string, list<int>>
+         * @return array<string, array<int, CodeIgniter\Files\FileSizeUnit>>
          */
         public static function provideGetSizeData()
         {
@@ Expand Down @@