#420: fix detection of java version when JAVA_TOOL_OPTIONS is set #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see what you means and I can't work on that now (PC broken and I don't want to mess with the one I use now). The loop seems "difficult", but as far as I remember, I looked for the error message in JDK and calls here : https://github.com/openjdk/jdk/blob/81e43114eca5199a0d816c02f50ecb6bc370135b/src/hotspot/share/runtime/arguments.cpp#L3074 I am more or less doing a job of removing the line sent by Another alternative I did not try would be probably to remove the offending env variable which might or not requires a patch to https://codehaus-plexus.github.io (if that's the good repo) or avoid inheriting them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix the issue I had at work (#420) by ignoring the "Picked up" based on what the JDK outputs.