fix: add retries to argo-event Sensors #593
Open
+159
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ATGardner
changed the title
ilia-medvedev-codefresh
approved these changes
Jul 21, 2025
Add a test case to verify that the HTTP trigger contains the correct policy settings when specified. This includes asserting that the status allows a response code of 200.
Add a test case to verify that the HTTP trigger contains the atLeastOnce field set to false when it is unset. This ensures proper behavior of the workflow reporter's sensor configuration.
Update the event bus name assignment to use a default value based on the event bus type. This change ensures that the event bus name is correctly set for both NATS and Jetstream configurations, improving the clarity and consistency of the event bus setup.
…w reporter" This reverts commit 807b6de.
ATGardner
force-pushed
the
CR-29995-fix-missing-events
branch
from
9ba2087 to
0306cc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
add templating options for argo-events Sensor trigger policy
Why
without a policy, it seems like it will almost never actually perform a retry. we are some policy values in sdlc tests, to decide if we should also have a default policy value.
Notes