-
Notifications
You must be signed in to change notification settings - Fork 0
WIP: グラフのWrapperの作成 #218 #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yawn-c111
wants to merge
22
commits into
dev
Choose a base branch
from
feature/graph-wrapper-#218
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oved visualization on test page
…rt visualization on test page
…guration on test page
…dant prop from filter.
…ies item styling.
…nd update GraphContainer to use children for flexibility
…ponents and update GraphStatusFilter to remove unused prop
… improved readability
…le breakpoint handling and adjusting layouts in GraphContainer, GraphSizeLegend, and GraphStatusFilter
…roved visual consistency
…and period selection, including responsive design and period options
…ons in app.css; remove redundant background color style from GraphWrapper component
…rightSection from GraphWrapper component and clean up periodConstants file
… new rightSection icon and improved leftSection styling; adjust padding for better layout consistency
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
先に #255 をレビュー・マージをお願いします。
イシュー #218 の実装です。
変更内容
新規コンポーネント
GraphWrapper: タイトルと期間選択のコンポーネントを持つラッパーコンポーネント追加ファイル
app/components/graph/GraphWrapper.tsx: GraphWrapperコンポーネント本体app/components/graph/periodConstants.ts: 期間選択のオプション定義スタイル変更
app/app.css: Mantine Selectのホバー/アクティブ/選択状態のスタイルを追加デモ更新
app/routes/test2.tsx: GraphWrapperを使用したデモに更新実装結果
Closes
Closes #218