added Signup with email and password #403
Conversation
Edu_Client_-_Google_Chrome_2021-09-07_21-36-51_Trim.mp4 |
There was a problem hiding this comment.
Awesome @YashKamboj ,
Few changes for future:
- Add email validation on textField.
- Add obscure password field
- Add a progress bar that shows the login is under progress
|
Thank you . |
|
@YashKamboj You can keep it in different PR or same, your choice 😄 |
| const [email, setEmail] = useState(""); | ||
| const [password, setPassword] = useState(""); | ||
| const [displayName, setDisplayName] = useState(""); |
There was a problem hiding this comment.
combine these three in one Object like:
const [user, setUser] = useState({});
to change the particular key in setState,
setUser({...user, key: value})
There was a problem hiding this comment.
Sorry! I am unable to combine ,when i combine then error shows of not defined , can you teach me how to do it.
There was a problem hiding this comment.
Please take a look at how it done.
The formData is the combined that that contains all the information about the form. See how it is used in textFields
| cfaSignIn("google.com").subscribe((user) => { | ||
| setuserData(user.displayName, user.email, user.photoURL); | ||
| user.sendEmailVerification(); |
There was a problem hiding this comment.
I think it's google signIn, this is mixing google signIn with email and password auth
There was a problem hiding this comment.
Hey i am really sorry , i do not know the user comes empty , can you please help
There was a problem hiding this comment.
Hey, Yash let's join on CFC discord under the project hangout section at 6 pm tomorrow I will explain the complete code base if it's fine.
There was a problem hiding this comment.
and we will discuss this issue also :)
|
Yes!! hoping there at 6 :)
…On Mon, Sep 13, 2021 at 9:52 PM Adarsh kumar singh ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/services/authService.js
<#403 (comment)>
:
> + cfaSignIn("google.com").subscribe((user) => {
+ setuserData(user.displayName, user.email, user.photoURL);
+ user.sendEmailVerification();
and we will discuss this issue also :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#403 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQU46FL4EFJTIHX4CM3TZEDUBYQNDANCNFSM5DQ6NM4A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
@Abhijay007 any progress |
@YashKamboj sorry for the late reply buddy, I tried it but was not able to find any optimal solutions, I suggest you ask @adarsh-technocrat about this issue as he already implemented something like this, you can message him on discord, maybe he can help you with this !! |
Ok thnx for your time |
Issue Number
#396
fixes #
Describe the changes you've made
Describe if there is any unusual behavior (Any Warning) of your code(Write
NAif there isn't)Additional context (OPTIONAL)
Test plan (OPTIONAL)
A good test plan should give instructions that someone else can easily follow.
Checklist
Provide a Deployed link of route/page that needs to review
Preview: Deploy preview link here with the appropriate route