Skip to content

Fix Tag Filters on Mobile View #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix Tag Filters on Mobile View #1809

wants to merge 2 commits into from
+1 −1

Conversation

kiminkim724
Copy link
Collaborator

@kiminkim724 kiminkim724 commented Apr 30, 2025 •
edited
Loading

Summary

  • Increased the limit of the tags RefinementList to allow all the tags to populate

Checklist

  • On the frontend, I've made my strings translate-able.
  • If I've added shared components, I've added a storybook story.
  • I've made pages responsive and look good on mobile.

Screenshots

Known issues

  • One thing to note is that selecting too many tags will stretch the screen, but that should be covered in a different ticket

Steps to test/reproduce

For each feature or bug fix, create a step by step list for how a reviewer can test it out. E.g.:

  1. Go to Bill Search in mobile view
  2. Select multiple tags and see if the view/selection stays the same without bugging out
  3. Close filters to see if the tags persist

@vercel Vercel
Copy link

vercel bot commented Apr 30, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maple-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2025 0:54am

Mephistic
Mephistic approved these changes Apr 30, 2025
View reviewed changes
Copy link
Collaborator

@Mephistic Mephistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mephistic Mephistic Mephistic approved these changes

@sashamaryl sashamaryl Awaiting requested review from sashamaryl sashamaryl is a code owner

@mertbagt mertbagt Awaiting requested review from mertbagt mertbagt is a code owner

@nesanders nesanders Awaiting requested review from nesanders nesanders is a code owner

@mvictor55 mvictor55 Awaiting requested review from mvictor55 mvictor55 is a code owner

@timblais timblais Awaiting requested review from timblais timblais is a code owner

@alexjball alexjball Awaiting requested review from alexjball alexjball is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiminkim724 @Mephistic