⚡️ Speed up function _check_cryptography by 42%

[codeflash-ai]

📄 42% (0.42x) speedup for _check_cryptography in src/requests/__init__.py

⏱️ Runtime : 252 microseconds → 178 microseconds (best of 45 runs)

📝 Explanation and details

To optimize the code for better runtime performance, we will focus on minimizing the operations within the function. The original code leverages try-except to handle version parsing, which can be slightly optimized by directly handling erroneous cases and reducing function calls. Here is the optimized version of the given code.

What changed in the optimized code?

• Replaced the list(map(...)) transformation with direct unpacking of the version components into major, minor, and patch, eliminating an extra list creation.
• Used a tuple to compare version numbers, which is more efficient and avoids the creation of a list within the function.
• Changed the string formatting to f-string for better performance and readability.
• Directly check for length of cryptography_version_list before attempting conversion to integers, potentially avoiding unnecessary handling.

These modifications should offer slight improvements in performance, particularly by reducing unnecessary function calls and handling the version components more efficiently.

✅ Correctness verification report:

Test	Status
⚙️ Existing Unit Tests	🔘 None Found
🌀 Generated Regression Tests	✅ 26 Passed
⏪ Replay Tests	🔘 None Found
🔎 Concolic Coverage Tests	🔘 None Found
📊 Tests Coverage	100.0%

🌀 Generated Regression Tests Details

import warnings

# imports
import pytest  # used for our unit tests
# function to test
from cryptography import __version__ as cryptography_version
from src.requests.__init__ import _check_cryptography
from src.requests.exceptions import RequestsDependencyWarning

# unit tests

def test_valid_versions_no_warning():
    """Test versions that should not trigger a warning."""
    valid_versions = ["1.3.4", "1.4.0", "2.0.0"]
    for version in valid_versions:
        with warnings.catch_warnings(record=True) as w:
            warnings.simplefilter("always")
            _check_cryptography(version)

def test_valid_versions_with_warning():
    """Test versions that should trigger a warning."""
    invalid_versions = ["1.3.3", "1.2.0", "0.9.8"]
    for version in invalid_versions:
        with warnings.catch_warnings(record=True) as w:
            warnings.simplefilter("always")
            _check_cryptography(version)

def test_malformed_versions():
    """Test malformed version strings that should not raise an exception."""
    malformed_versions = ["1.3.a", "1..4", "1.3.4-beta", "1.3", "1", ""]
    for version in malformed_versions:
        with warnings.catch_warnings(record=True) as w:
            warnings.simplefilter("always")
            _check_cryptography(version)

def test_edge_cases():
    """Test edge cases including very large version numbers and boundary values."""
    edge_cases = {
        "999.999.999": False,
        "1000.0.0": False,
        "1.3.4": False,  # exact boundary
        "1.3.3": True,   # just below the boundary
        "1.3.5": False   # just above the boundary
    }
    for version, should_warn in edge_cases.items():
        with warnings.catch_warnings(record=True) as w:
            warnings.simplefilter("always")
            _check_cryptography(version)
            if should_warn:
                pass
            else:
                pass

def test_non_standard_formats():
    """Test non-standard version formats."""
    non_standard_versions = ["01.003.004", "001.000.000", "1.3.4.1", "1.3.4.0.0"]
    for version in non_standard_versions:
        with warnings.catch_warnings(record=True) as w:
            warnings.simplefilter("always")
            _check_cryptography(version)

def test_large_scale_versions():
    """Test large scale version strings."""
    large_versions = ["1.3.4" * 100, "1.3.4.5.6.7.8.9.10"]
    for version in large_versions:
        with warnings.catch_warnings(record=True) as w:
            warnings.simplefilter("always")
            _check_cryptography(version)



import warnings

# imports
import pytest  # used for our unit tests
from cryptography import __version__ as cryptography_version
from src.requests.__init__ import _check_cryptography
from src.requests.exceptions import RequestsDependencyWarning


# unit tests
def test_valid_version_below_threshold():
    with pytest.warns(RequestsDependencyWarning, match="Old version of cryptography"):
        _check_cryptography("1.3.3")












def test_very_small_version_numbers():
    with pytest.warns(RequestsDependencyWarning, match="Old version of cryptography"):
        _check_cryptography("0.0.0")

def test_boundary_just_below_threshold():
    with pytest.warns(RequestsDependencyWarning, match="Old version of cryptography"):
        _check_cryptography("1.3.3")

📢 Feedback on this optimization?