Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaScript #3

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

JavaScript #3

wants to merge 8 commits into from

Conversation

AniKhosteghyan
Copy link

No description provided.

styopdev
styopdev requested changes Oct 14, 2019
View reviewed changes
README.md Outdated

var arr=[];
var n=0;;
var m=0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use global variables, move n and m inside of function's body

README.md

function sorT(arr){

for(var i=0; i<arr.length;i++){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use forEach instead of for

README.md Outdated

for(var i=0; i<arr.length;i++){

if( typeof(arr[i]) == 'number' )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always use brackets after if / else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styopdev styopdev styopdev requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AniKhosteghyan @styopdev