Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump firebase dependency to ^10.0.0 #154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrdavidlaing
Copy link

npm i sveltefire firebase currently fails:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/firebase
npm ERR!   firebase@"^10.8.1" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer firebase@"^9.0.0" from [email protected]
npm ERR! node_modules/sveltefire
npm ERR!   sveltefire@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

When installed ignoring the dependency conflict - ie: npm i sveltefire firebase --legacy-peer-deps - things appear to work.

Can we upgrade to the latest firebase version?

@IanSaucy
Copy link

+1
V10 doesn't appear to introduce any breaking changes that are relevant to this project: https://firebase.google.com/support/release-notes/js#version_1000_-_july_6_2023

@RonnyRoos
Copy link

+1, please merge

@RonnyRoos
Copy link

@codediodeio, did you get a chance to look at this?
There is at least one issue (#126) related to this, and afaik this would fix the problems without anything breaking.

@IanSaucy
Copy link

For anyone else, I posted a way to deal with this issue in a cleaner way than forcing legacy peer deps.

#126 (comment)

@corne-ac
Copy link

+1

@urmoov-dev
Copy link

For anyone else, I posted a way to deal with this issue in a cleaner way than forcing legacy peer deps.

#126 (comment)

Thanks for this man, fixed the problem when deploying to Firebase using the Frameworks Experiments.

@shep920
Copy link

shep920 commented Jul 21, 2024

Pls merge, its a one line change.

@purplelemons-dev
Copy link

+1 please merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants