Use Is_disjoint optimization in Shadow Mode#538
Open
maxweng-sentry wants to merge 7 commits intomainfrom
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #538 +/- ##
==========================================
+ Coverage 93.82% 93.83% +0.01%
==========================================
Files 1280 1282 +2
Lines 46120 46336 +216
Branches 1511 1527 +16
==========================================
+ Hits 43272 43480 +208
- Misses 2540 2547 +7
- Partials 308 309 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #538 will not alter performanceComparing Summary
Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address this issue:
https://linear.app/getsentry/project/report-merging-improvements-89f3063419db/overview
Primary Fix: Use the
is_disjointOptimization in Shadow ModeThe
Report.merge()method has a built-in optimization that wasn't being used:is_disjoint=True: Defers expensive line-by-line merging, just appends coverage recordsfinish_merge(): Performs actual merging in one pass at the endChanges:
In
libs/shared/shared/utils/merge.pydeduplicate_sessionsfunction that will run withinfinish_mergethat will correctly mergeLineSessionsIn
apps/worker/services/processing/merging.py