fix: move tasks to experimental module and undo notifier tauploadcontext#512
Open
joseph-sentry wants to merge 1 commit intomainfrom
Open
fix: move tasks to experimental module and undo notifier tauploadcontext#512joseph-sentry wants to merge 1 commit intomainfrom
joseph-sentry wants to merge 1 commit intomainfrom
Conversation
Contributor
joseph-sentry
commented
Sep 25, 2025
joseph-sentry
commented
- clarify the tasks that are simply experimental and not actually meant for use in prod currently
- remove TAUploadContext type from commit in BaseNotifier constructor type signature: we don't want to have to worry about this case since it's not being used in prod
- clarify the tasks that are simply experimental and not actually meant for use in prod currently - remove TAUploadContext type from commit in BaseNotifier constructor type signature: we don't want to have to worry about this case since it's not being used in prod
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #512 +/- ##
=======================================
Coverage 93.81% 93.82%
=======================================
Files 1279 1279
Lines 46087 46080 -7
Branches 1511 1511
=======================================
- Hits 43238 43233 -5
+ Misses 2541 2539 -2
Partials 308 308
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ajay-sentry
reviewed
Sep 25, 2025
| @@ -0,0 +1,39 @@ | |||
| # Experimental Test Analytics Tasks | |||
|
|
|||
| This module contains an experimental pipeline that mirrors an aspirational Test Analytics (TA) flow. The code is **not** production-ready—each task exists solely for exploration and will evolve substantially before promotion. | |||
Contributor
There was a problem hiding this comment.
can you add this was generated by claude
ajay-sentry
reviewed
Sep 25, 2025
| notifier = TestResultsNotifier( | ||
| repo, | ||
| upload_context, | ||
| upload_context, # TODO: this won't work because test results notifier doesn't currently support the TAUpload Context |
Contributor
There was a problem hiding this comment.
can you elaborate on "this won't work"
Should we just comment out the whole param to avoid the footgun?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.