Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: update jsdom to remove punycode warning #3605

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ajay-sentry
Copy link
Contributor

Description

Was getting SUPER annoyed with the punycode deprecation warning and wanted to get to the bottom of it.

Turns out it was due to a couple packages that were out of date on jsdom, that are subsequently patched in v25.0.1

Changelog

Screenshots

BEFORE

Screenshot 2024-12-20 at 3 44 09 PM

AFTER

Screenshot 2024-12-20 at 3 43 44 PM

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Dec 20, 2024

Bundle Report

Bundle size has no change ✅

@codecov-staging
Copy link

Bundle Report

Bundle size has no change ✅

@codecov-notifications
Copy link

codecov-notifications bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3605   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files         810      810           
  Lines       14569    14569           
  Branches     4154     4154           
=======================================
  Hits        14424    14424           
  Misses        138      138           
  Partials        7        7           
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.75% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.32% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdd77d4...345cfc8. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (fdd77d4) to head (345cfc8).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3605   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files         810      810           
  Lines       14569    14569           
  Branches     4154     4161    +7     
=======================================
  Hits        14424    14424           
  Misses        138      138           
  Partials        7        7           
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.75% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.32% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdd77d4...345cfc8. Read the comment docs.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (fdd77d4) to head (345cfc8).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3605   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files         810      810           
  Lines       14569    14569           
  Branches     4161     4154    -7     
=======================================
  Hits        14424    14424           
  Misses        138      138           
  Partials        7        7           
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.75% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.32% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdd77d4...345cfc8. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
345cfc8 Fri, 20 Dec 2024 23:50:07 GMT Cloud Enterprise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants