-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: update jsdom to remove punycode warning #3605
base: main
Are you sure you want to change the base?
Conversation
Bundle ReportBundle size has no change ✅ |
Bundle ReportBundle size has no change ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3605 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 810 810
Lines 14569 14569
Branches 4154 4154
=======================================
Hits 14424 14424
Misses 138 138
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3605 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 810 810
Lines 14569 14569
Branches 4154 4161 +7
=======================================
Hits 14424 14424
Misses 138 138
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3605 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 810 810
Lines 14569 14569
Branches 4161 4154 -7
=======================================
Hits 14424 14424
Misses 138 138
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Description
Was getting SUPER annoyed with the punycode deprecation warning and wanted to get to the bottom of it.
Turns out it was due to a couple packages that were out of date on jsdom, that are subsequently patched in v25.0.1
Changelog
Screenshots
BEFORE
AFTER
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.