ref: Convert isBasicPlan to isFreePlan GQL property #3600
Conversation
Bundle ReportChanges will decrease total bundle size by 148 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3600 +/- ##
==========================================
- Coverage 99.00% 99.00% -0.01%
==========================================
Files 810 810
Lines 14557 14551 -6
Branches 4139 4136 -3
==========================================
- Hits 14412 14406 -6
Misses 138 138
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will decrease total bundle size by 148 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3600 +/- ##
==========================================
- Coverage 99.00% 99.00% -0.01%
==========================================
Files 810 810
Lines 14557 14551 -6
Branches 4139 4143 +4
==========================================
- Hits 14412 14406 -6
Misses 138 138
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3600 +/- ##
==========================================
- Coverage 99.00% 99.00% -0.01%
==========================================
Files 810 810
Lines 14557 14551 -6
Branches 4146 4143 -3
==========================================
- Hits 14412 14406 -6
Misses 138 138
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3600 +/- ##
==========================================
- Coverage 99.00% 99.00% -0.01%
==========================================
Files 810 810
Lines 14557 14551 -6
Branches 4146 4136 -10
==========================================
- Hits 14412 14406 -6
Misses 138 138
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Description
isBasicPlan looked to only be used in two places, both related to trials. After talking with @aj-codecov and @adrian-codecov we thought that shifting to all free plans, as long as they haven't trialed before, made sense to us allowing us to remove some extra overhead with logic and just rely on isFreePlan in a few more places.
Luckily because the schemas all stayed the same this PR remained pretty lightweight.
Closes codecov/engineering-team#3002
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.