Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Migrate useSelfHostedCurrentUser to TS Query V5 #3582

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

chore: Migrate useSelfHostedCurrentUser to TS Query V5 #3582

wants to merge 8 commits into from

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR migrates the useSelfHostedCurrentUser to the TS Query V5 queryOptions API version SelfHostedCurrentUserQueryOpts

Ticket: codecov/engineering-team#2961

Notable Changes

  • Migrate useSelfHostedCurrentUser to SelfHostedCurrentUserQueryOpts
  • Update usage in AdminLink, Profile, ActivationBanner, useSelfActivationMutation, AdminSettings, ActivationRequiredSelfHosted` x 2

@codecov-staging
Copy link

codecov-staging bot commented Dec 13, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 2.43kB (-0.01%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.72MB 1.14kB (-0.02%) ⬇️
gazebo-staging-system 5.67MB 1.3kB (-0.02%) ⬇️

@codecov Codecov
Copy link

codecov bot commented Dec 13, 2024

Bundle Report

Changes will decrease total bundle size by 2.43kB (-0.01%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.67MB 1.3kB (-0.02%) ⬇️
gazebo-production-system-esm 5.72MB 1.14kB (-0.02%) ⬇️

@codecov-notifications
Copy link

codecov-notifications bot commented Dec 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3582      +/-   ##
==========================================
- Coverage   98.91%   98.91%   -0.01%     
==========================================
  Files         806      806              
  Lines       14498    14505       +7     
  Branches     4119     4113       -6     
==========================================
+ Hits        14341    14347       +6     
- Misses        150      151       +1     
  Partials        7        7
Files with missing lines Coverage Δ
.../layouts/Header/components/AdminLink/AdminLink.tsx 100.00% <100.00%> (ø)
...tabs/Profile/ActivationBanner/ActivationBanner.jsx 100.00% <100.00%> (ø)
...file/ActivationBanner/useSelfActivationMutation.js 100.00% <100.00%> (ø)
src/pages/AccountSettings/tabs/Profile/Profile.jsx 88.88% <100.00%> (-11.12%) ⬇️
src/pages/AdminSettings/AdminSettings.jsx 100.00% <100.00%> (ø)
...equiredSelfHosted/ActivationRequiredSelfHosted.tsx 100.00% <100.00%> (ø)
...equiredSelfHosted/ActivationRequiredSelfHosted.tsx 100.00% <100.00%> (ø)
...vices/selfHosted/SelfHostedCurrentUserQueryOpts.ts 88.88% <100.00%> (ø)

... and 19 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <100.00%> (+<0.01%) ⬆️
Pages 98.58% <100.00%> (-0.02%) ⬇️
Services 99.36% <100.00%> (ø)
Shared 99.32% <ø> (+<0.01%) ⬆️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d09206c...1cca9c1. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Dec 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (d09206c) to head (1cca9c1).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3582      +/-   ##
==========================================
- Coverage   98.91%   98.91%   -0.01%     
==========================================
  Files         806      806              
  Lines       14498    14505       +7     
  Branches     4112     4120       +8     
==========================================
+ Hits        14341    14347       +6     
- Misses        150      151       +1     
  Partials        7        7
Files with missing lines Coverage Δ
.../layouts/Header/components/AdminLink/AdminLink.tsx 100.00% <100.00%> (ø)
...tabs/Profile/ActivationBanner/ActivationBanner.jsx 100.00% <100.00%> (ø)
...file/ActivationBanner/useSelfActivationMutation.js 100.00% <100.00%> (ø)
src/pages/AccountSettings/tabs/Profile/Profile.jsx 88.88% <100.00%> (-11.12%) ⬇️
src/pages/AdminSettings/AdminSettings.jsx 100.00% <100.00%> (ø)
...equiredSelfHosted/ActivationRequiredSelfHosted.tsx 100.00% <100.00%> (ø)
...equiredSelfHosted/ActivationRequiredSelfHosted.tsx 100.00% <100.00%> (ø)
...vices/selfHosted/SelfHostedCurrentUserQueryOpts.ts 88.88% <100.00%> (ø)

... and 19 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <100.00%> (+<0.01%) ⬆️
Pages 98.58% <100.00%> (-0.02%) ⬇️
Services 99.36% <100.00%> (ø)
Shared 99.32% <ø> (+<0.01%) ⬆️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d09206c...1cca9c1. Read the comment docs.

@codecov-public-qa Codecov Public QA
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (d09206c) to head (1cca9c1).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3582      +/-   ##
==========================================
- Coverage   98.91%   98.91%   -0.01%     
==========================================
  Files         806      806              
  Lines       14498    14505       +7     
  Branches     4112     4113       +1     
==========================================
+ Hits        14341    14347       +6     
- Misses        150      151       +1     
  Partials        7        7
Files with missing lines Coverage Δ
.../layouts/Header/components/AdminLink/AdminLink.tsx 100.00% <100.00%> (ø)
...tabs/Profile/ActivationBanner/ActivationBanner.jsx 100.00% <100.00%> (ø)
...file/ActivationBanner/useSelfActivationMutation.js 100.00% <100.00%> (ø)
src/pages/AccountSettings/tabs/Profile/Profile.jsx 88.88% <100.00%> (-11.12%) ⬇️
src/pages/AdminSettings/AdminSettings.jsx 100.00% <100.00%> (ø)
...equiredSelfHosted/ActivationRequiredSelfHosted.tsx 100.00% <100.00%> (ø)
...equiredSelfHosted/ActivationRequiredSelfHosted.tsx 100.00% <100.00%> (ø)
...vices/selfHosted/SelfHostedCurrentUserQueryOpts.ts 88.88% <100.00%> (ø)

... and 19 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <100.00%> (+<0.01%) ⬆️
Pages 98.58% <100.00%> (-0.02%) ⬇️
Services 99.36% <100.00%> (ø)
Shared 99.32% <ø> (+<0.01%) ⬆️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d09206c...1cca9c1. Read the comment docs.

@codecov Codecov
Copy link

codecov bot commented Dec 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (d09206c) to head (1cca9c1).
Report is 14 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3582      +/-   ##
==========================================
- Coverage   98.91%   98.91%   -0.01%     
==========================================
  Files         806      806              
  Lines       14498    14505       +7     
  Branches     4119     4120       +1     
==========================================
+ Hits        14341    14347       +6     
- Misses        150      151       +1     
  Partials        7        7
Files with missing lines Coverage Δ
.../layouts/Header/components/AdminLink/AdminLink.tsx 100.00% <100.00%> (ø)
...tabs/Profile/ActivationBanner/ActivationBanner.jsx 100.00% <100.00%> (ø)
...file/ActivationBanner/useSelfActivationMutation.js 100.00% <100.00%> (ø)
src/pages/AccountSettings/tabs/Profile/Profile.jsx 88.88% <100.00%> (-11.12%) ⬇️
src/pages/AdminSettings/AdminSettings.jsx 100.00% <100.00%> (ø)
...equiredSelfHosted/ActivationRequiredSelfHosted.tsx 100.00% <100.00%> (ø)
...equiredSelfHosted/ActivationRequiredSelfHosted.tsx 100.00% <100.00%> (ø)
...vices/selfHosted/SelfHostedCurrentUserQueryOpts.ts 88.88% <100.00%> (ø)

... and 19 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <100.00%> (+<0.01%) ⬆️
Pages 98.58% <100.00%> (-0.02%) ⬇️
Services 99.36% <100.00%> (ø)
Shared 99.32% <ø> (+<0.01%) ⬆️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d09206c...1cca9c1. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
1cca9c1 Fri, 13 Dec 2024 18:33:23 GMT Cloud Enterprise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholas-codecov @codecov-releaser