Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issue with building Typedocs #233

Merged
merged 3 commits into from
Dec 31, 2024

Conversation

nicholas-codecov
Copy link
Collaborator

Description

When updating the dependences in the previous PR I missed checking to see if the typedocs would still build, this PR resolves an issue with how they are being built. I've also added in a CI step to check to see if we're able to build the docs.

Notable Changes

  • Refactor plugin to ESM
  • Update references
  • Add in CI step to check if docs are able to be built

@codecov-notifications
Copy link

codecov-notifications bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Components Coverage Δ
Plugin core 98.69% <ø> (ø)
Rollup plugin 9.58% <ø> (ø)
Vite plugin 9.81% <ø> (ø)
Webpack plugin 61.33% <ø> (ø)

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.54%. Comparing base (c2a6fc2) to head (0cfbf01).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
Components Coverage Δ
Plugin core 98.69% <ø> (ø)
Rollup plugin 9.58% <ø> (ø)
Vite plugin 9.81% <ø> (ø)
Webpack plugin 61.33% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov bot commented Dec 30, 2024

Bundle Report

Changes will decrease total bundle size by 142 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@codecov/solidstart-plugin-esm 949 bytes 142 bytes (-13.02%) ⬇️

@codecov-staging
Copy link

codecov-staging bot commented Dec 30, 2024

Bundle Report

Bundle size has no change ✅

Copy link
Contributor

@suejung-sentry suejung-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice addition

@nicholas-codecov nicholas-codecov merged commit 0542128 into main Dec 31, 2024
69 checks passed
@nicholas-codecov nicholas-codecov deleted the fix-issue-with-building-typedocs branch December 31, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants