fix(plugin): guard against undefined step.name in retryFailedStep#5562
Open
gololdf1sh wants to merge 1 commit into
Open
fix(plugin): guard against undefined step.name in retryFailedStep#5562gololdf1sh wants to merge 1 commit into
gololdf1sh wants to merge 1 commit into
Conversation
…rkers In `run-workers` mode, step events are serialized via `step.simplify()` which maps `step.name` to `title` (not `name`). The `retryFailedStep` plugin only checked `step.name`, which is `undefined` for simplified step objects, causing a TypeError crash in the `ignoredSteps` loop. Use `step.name || step.title` so the plugin works with both full Step objects (in-process) and simplified ones (from workers). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
a0599c8 to
7a96d61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When running tests in
run-workersmode withretryFailedStepenabled, step events are serialized viastep.simplify()before being sent from worker to master process.simplify()mapsstep.name→title:The
retryFailedStepplugin only readsstep.name, which isundefinedon simplified objects. TheignoredStepsloop then calls.startsWith()/.match()onundefined, crashing the worker:Fix
Use
step.name || step.titleso the plugin works with both full Step objects (in-process) and simplified ones (from workers). Falls back to an earlyreturnif neither is present.Testing
run-workersmode (2 workers, 4 tests) — workers crashed consistentlytest/unit/plugin/retryFailedStep_test.js— 5 passing, 4 pending/skipped pre-existing)