Add safeguards fo finish in pause.js #5461 by incoming-th · Pull Request #5507 · codeceptjs/CodeceptJS

incoming-th · 2026-04-07T14:38:38Z

Motivation/Description of the PR

Error processing test.finish event: TypeError: finish is not a function

Resolves Error processing test.finish event: TypeError: finish is not a function #5461

Applicable helpers:

Applicable plugins:

Type of change

Checklist:

Tests have been added
Documentation has been added (Run npm run docs)
Lint checking (Run npm run lint)
Local tests are passed (Run npm test)

Bumps [playwright](https://github.com/microsoft/playwright) from 1.53.0 to 1.54.1. - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.53.0...v1.54.1) --- updated-dependencies: - dependency-name: playwright dependency-version: 1.54.1 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

--- updated-dependencies: - dependency-name: "@eslint/js" dependency-version: 9.31.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [expect](https://github.com/jestjs/jest/tree/HEAD/packages/expect) from 29.7.0 to 30.0.4. - [Release notes](https://github.com/jestjs/jest/releases) - [Changelog](https://github.com/jestjs/jest/blob/main/CHANGELOG.md) - [Commits](https://github.com/jestjs/jest/commits/v30.0.4/packages/expect) --- updated-dependencies: - dependency-name: expect dependency-version: 30.0.4 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [graphql](https://github.com/graphql/graphql-js) from 16.10.0 to 16.11.0. - [Release notes](https://github.com/graphql/graphql-js/releases) - [Commits](graphql/graphql-js@v16.10.0...v16.11.0) --- updated-dependencies: - dependency-name: graphql dependency-version: 16.11.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [electron](https://github.com/electron/electron) from 37.1.0 to 37.2.3. - [Release notes](https://github.com/electron/electron/releases) - [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md) - [Commits](electron/electron@v37.1.0...v37.2.3) --- updated-dependencies: - dependency-name: electron dependency-version: 37.2.3 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [axios](https://github.com/axios/axios) from 1.8.4 to 1.11.0. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.8.4...v1.11.0) --- updated-dependencies: - dependency-name: axios dependency-version: 1.11.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…deceptjs#5046) Bumps [typedoc-plugin-markdown](https://github.com/typedoc2md/typedoc-plugin-markdown/tree/HEAD/packages/typedoc-plugin-markdown) from 4.7.0 to 4.7.1. - [Release notes](https://github.com/typedoc2md/typedoc-plugin-markdown/releases) - [Changelog](https://github.com/typedoc2md/typedoc-plugin-markdown/blob/main/packages/typedoc-plugin-markdown/CHANGELOG.md) - [Commits](https://github.com/typedoc2md/typedoc-plugin-markdown/commits/typedoc-plugin-markdown@4.7.1/packages/typedoc-plugin-markdown) --- updated-dependencies: - dependency-name: typedoc-plugin-markdown dependency-version: 4.7.1 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…s#5041) Bumps [browser-actions/setup-chrome](https://github.com/browser-actions/setup-chrome) from 1 to 2. - [Release notes](https://github.com/browser-actions/setup-chrome/releases) - [Changelog](https://github.com/browser-actions/setup-chrome/blob/master/CHANGELOG.md) - [Commits](browser-actions/setup-chrome@v1...v2) --- updated-dependencies: - dependency-name: browser-actions/setup-chrome dependency-version: '2' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [typedoc](https://github.com/TypeStrong/TypeDoc) from 0.28.7 to 0.28.10. - [Release notes](https://github.com/TypeStrong/TypeDoc/releases) - [Changelog](https://github.com/TypeStrong/typedoc/blob/master/CHANGELOG.md) - [Commits](TypeStrong/typedoc@v0.28.7...v0.28.10) --- updated-dependencies: - dependency-name: typedoc dependency-version: 0.28.10 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: hook exit code * Update asyncWrapper.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update asyncWrapper.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update asyncWrapper.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update asyncWrapper.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update asyncWrapper.js * Update asyncWrapper.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…odeceptjs#5072) * fix share workers * fix share workers

Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [tsd](https://github.com/tsdjs/tsd) from 0.32.0 to 0.33.0. - [Release notes](https://github.com/tsdjs/tsd/releases) - [Commits](tsdjs/tsd@v0.32.0...v0.33.0) --- updated-dependencies: - dependency-name: tsd dependency-version: 0.33.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…deceptjs#5067) Bumps [typedoc-plugin-markdown](https://github.com/typedoc2md/typedoc-plugin-markdown/tree/HEAD/packages/typedoc-plugin-markdown) from 4.7.1 to 4.8.1. - [Release notes](https://github.com/typedoc2md/typedoc-plugin-markdown/releases) - [Changelog](https://github.com/typedoc2md/typedoc-plugin-markdown/blob/main/packages/typedoc-plugin-markdown/CHANGELOG.md) - [Commits](https://github.com/typedoc2md/typedoc-plugin-markdown/commits/typedoc-plugin-markdown@4.8.1/packages/typedoc-plugin-markdown) --- updated-dependencies: - dependency-name: typedoc-plugin-markdown dependency-version: 4.8.1 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

codeceptjs#5073)

* release 3.7.4

…Timeout` value at the end of test suite (codeceptjs#5077) * Initial plan * Changes before error encountered Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>

* Initial plan * Changes before error encountered Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>

codeceptjs#5082) * Initial plan * Fix JUnit XML test case name inconsistency in scenario retries Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com> * Improve edge case handling for empty suite titles in cloned tests Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>

* fix: TestCafe_test.js * Fix TestCafe form submission timeout with efficient polling mechanism (codeceptjs#5080) * Initial plan * Fix failed TestCafe tests by skipping doubleClick test * Update testcafe.yml * Update testcafe.yml * Update TestCafe_test.js * Update TestCafe_test.js * Changes before error encountered Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com> * Fix TestCafe form submission timeout in CI environments * Improve TestCafe form submission timeout handling with polling mechanism Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com> * Improve TestCafe form submission timeout with efficient polling mechanism Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com> * Changes before error encountered Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com> * Changes before error encountered Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com> * Changes before error encountered Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com> * Update testcafe.yml * fix: Chrome popup causes problems with TestCafe --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com> Co-authored-by: kobenguyent <kobenguyent@gmail.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>

* Initial plan * Changes before error encountered Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com> * Add TypeScript types for Feature.only method * Changes before error encountered Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com> * Fix TypeScript test expectations for hook return types Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>

* Initial plan * Changes before error encountered Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com> * Changes before error encountered Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>

* Fix open security issues * Update more packages

* Create gitleaks.yml * Update gitleaks.yml

…odeceptjs#5534)

kobenguyent · 2026-06-02T12:54:12Z

@incoming-th as of now the base branch is 4.x, could you help resolve this?

incoming-th · 2026-06-04T02:05:48Z

@kobenguyent Happy to help but I am still on 3.7.x release. Is there any breaking change to 4.x that we should be aware of? I read the doc but not sure if we can safely just upgrade to 4.x

kobenguyent · 2026-06-04T05:31:21Z

@incoming-th maybe this helps https://codecept.io/blog/codeceptjs-4/

incoming-th · 2026-06-07T14:38:20Z

@kobenguyent #5612 So this one can be closed I guess?

dependabot Bot and others added 30 commits July 16, 2025 09:36

chore(deps-dev): bump puppeteer from 24.8.0 to 24.15.0 (codeceptjs#5054)

2aef872

chore(deps-dev): bump expect from 30.0.4 to 30.0.5 (codeceptjs#5064)

e090eb9

fix: 5070 issue (codeceptjs#5071)

220b73f

5066 unable to inject data between workers because of proxy object (c…

3cf5fe2

…odeceptjs#5072) * fix share workers * fix share workers

feat: shuffle test suite order in run command (codeceptjs#5051)

4daabc8

fix: sessions playwright traces - naming convention and error handling (

ff63f70

codeceptjs#5073)

release 3.7.4 (codeceptjs#5075)

a483106

* release 3.7.4

update docs

2e4d0bb

fix: Update inquirer (codeceptjs#5076)

376c758

add docs

f0759ca

feat(cli): make test file hyperlink (codeceptjs#5078)

04ec768

thomashohn and others added 9 commits March 5, 2026 16:11

Update Sinon (codeceptjs#5472)

c6b3da2

Added overwrites (codeceptjs#5477)

47451b3

Updated deps (codeceptjs#5488)

1324e07

Update actions (codeceptjs#5490)

11511b4

Bump versions (codeceptjs#5494)

051ced8

release 3.7.7 (codeceptjs#5495)

30a36a6

Fix open security issues (codeceptjs#5504)

83cb43d

* Fix open security issues * Update more packages

Add safeguards fo finish in pause.js codeceptjs#5461

2a33065

Create gitleaks.yml (codeceptjs#5505)

80d483e

* Create gitleaks.yml * Update gitleaks.yml

kobenguyent requested a review from DavertMik April 8, 2026 03:25

thomashohn and others added 6 commits April 8, 2026 08:52

Update dependencies (codeceptjs#5510)

1737c67

release 3.7.8 (codeceptjs#5511)

138d28e

Fix critical security issue in axios (codeceptjs#5517)

bb9263c

Align docker playwrigth version with composer (codeceptjs#5521)

236b15c

Update outdated packages and security fixes (codeceptjs#5523)

b5498c6

Fix securit issue in axios and updated deps (codeceptjs#5530)

712a57b

kobenguyent requested a review from DenysKuchma April 22, 2026 09:45

thomashohn and others added 5 commits April 23, 2026 07:39

Fix all occurences of @xmldom/xmldom to 0.9.10 and removed override (c…

16297a4

…odeceptjs#5534)

Run gitleaks.yml only on codeceptjs org

93afd27

release 3.7.9 (codeceptjs#5535)

cd374a0

Update axios to fix security issue and other deps (codeceptjs#5540)

9e4576b

Update outdated deps (codeceptjs#5570)

a931bde

kobenguyent changed the base branch from 3.x to 4.x May 26, 2026 03:27

kobenguyent assigned incoming-th Jun 2, 2026

kobenguyent added the bug label Jun 5, 2026

Merge branch 'codeceptjs:3.x' into 3.x

6a68cc9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add safeguards fo finish in pause.js #5461#5507

Add safeguards fo finish in pause.js #5461#5507
incoming-th wants to merge 151 commits into
codeceptjs:4.xfrom
incoming-th:3.x

incoming-th commented Apr 7, 2026

Uh oh!

kobenguyent commented Jun 2, 2026

Uh oh!

incoming-th commented Jun 4, 2026 •

edited

Loading

Uh oh!

kobenguyent commented Jun 4, 2026

Uh oh!

incoming-th commented Jun 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

Uh oh!

Conversation

incoming-th commented Apr 7, 2026

Motivation/Description of the PR

Type of change

Checklist:

Uh oh!

kobenguyent commented Jun 2, 2026

Uh oh!

incoming-th commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kobenguyent commented Jun 4, 2026

Uh oh!

incoming-th commented Jun 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

incoming-th commented Jun 4, 2026 •

edited

Loading