fix update logic (#281)

code4romania · Sep 4, 2023 · b39e60c · b39e60c
1 parent 8691827
commit b39e60c
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/app/Services/OrganizationService.php b/app/Services/OrganizationService.php
@@ -16,12 +16,6 @@ public static function update(Organization $organization, array $attributes)
         $key = $attributes->keys()->first();
         $value = $attributes->get($key);
 
-        if (! \in_array($key, $organization->requiresApproval)) {
-            $organization->update($attributes->all());
-
-            return;
-        }
-
         return match ($key) {
             'counties' => $organization->counties()
                 ->sync(collect($value)->pluck('id')),
@@ -34,7 +28,9 @@ public static function update(Organization $organization, array $attributes)
 
             'statute' => static::saveStatue($organization, $value),
 
-            default => $organization->fill($attributes->all())->saveForApproval(),
+            default => \in_array($key, $organization->requiresApproval)
+                ? $organization->fill($attributes->all())->saveForApproval()
+                : $organization->update($attributes->all()),
         };
     }