-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/admin UI #553
Feat/admin UI #553
Conversation
@VineeTagarwaL-code done with the work |
payment history wasnt needed, and the recruiters are the ones with hr role right ? |
@VineeTagarwaL-code payment history was there in the screenshot you provided, yes the recruiters are the one with hr role. |
Remove the payment history rest are good |
@VineeTagarwaL-code removed payment history |
src/app/manage/recruiters/page.tsx
Outdated
import { redirect } from 'next/navigation'; | ||
import React from 'react'; | ||
|
||
const ManagePayment = async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is manage payment code existing here ?
src/app/manage/recruiters/page.tsx
Outdated
} else if (server.user.role !== 'ADMIN') { | ||
redirect('/jobs'); | ||
} | ||
const Recruiters = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are recruiters hardcoded here ? shouldnt they be fetched from the database ?
src/components/DeleteDialog.tsx
Outdated
@@ -13,7 +13,7 @@ import { | |||
DialogDescription, | |||
DialogFooter, | |||
} from './ui/dialog'; | |||
import { ArchiveRestore, Trash } from 'lucide-react'; | |||
import { ArchiveRestore, Trash2 } from 'lucide-react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use icon file we have and import it from there, do the favour for archiveRestore too
src/config/path.config.ts
Outdated
@@ -5,7 +5,10 @@ const APP_PATHS = { | |||
SIGNUP: '/signup', | |||
RESET_PASSWORD: '/reset-password', | |||
JOBS: '/jobs', | |||
MANAGE_JOBS: '/manage', | |||
|
|||
PAYMENT_HISTORY: '/manage/payments', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is manage payment code existing here ?
Seems full of bugs here, fix it |
@VineeTagarwaL-code ok I will work on changes, also for the recruiters, should I fetch users from db with hr role ?? |
Answered you in dms |
@VineeTagarwaL-code hr should have some relation with the company they are managing, so should i create a company model which have relation with the hr |
Screen.Recording.2024-10-27.232445.mp4@VineeTagarwaL-code done with the changes |
Have you fixed that bug ? its still replicating |
Screen.Recording.2024-10-29.200243.mp4@VineeTagarwaL-code its working fine.. |
@VineeTagarwaL-code done |
can you do the same for recruiters page ? and dont squeeze it too much just minimal space between the borders of the screen will work |
|
Great pr, make sure you on post on x and tag me ! |
Screen.Recording.2024-10-25.011123.mp4
#547