Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/admin UI #553

Merged
merged 17 commits into from
Oct 31, 2024
Merged

Feat/admin UI #553

merged 17 commits into from
Oct 31, 2024

Conversation

Paribesh01
Copy link
Contributor

@Paribesh01 Paribesh01 commented Oct 24, 2024

Screen.Recording.2024-10-25.011123.mp4

#547

@Paribesh01
Copy link
Contributor Author

@VineeTagarwaL-code done with the work

@VineeTagarwaL-code
Copy link
Collaborator

payment history wasnt needed, and the recruiters are the ones with hr role right ?

@Paribesh01
Copy link
Contributor Author

Paribesh01 commented Oct 26, 2024

@VineeTagarwaL-code payment history was there in the screenshot you provided, yes the recruiters are the one with hr role.
should i also create pages for the recruitres, as they are similar it will take no time.

@VineeTagarwaL-code
Copy link
Collaborator

Remove the payment history rest are good

@Paribesh01
Copy link
Contributor Author

@VineeTagarwaL-code removed payment history

import { redirect } from 'next/navigation';
import React from 'react';

const ManagePayment = async () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is manage payment code existing here ?

} else if (server.user.role !== 'ADMIN') {
redirect('/jobs');
}
const Recruiters = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are recruiters hardcoded here ? shouldnt they be fetched from the database ?

@@ -13,7 +13,7 @@ import {
DialogDescription,
DialogFooter,
} from './ui/dialog';
import { ArchiveRestore, Trash } from 'lucide-react';
import { ArchiveRestore, Trash2 } from 'lucide-react';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use icon file we have and import it from there, do the favour for archiveRestore too

@@ -5,7 +5,10 @@ const APP_PATHS = {
SIGNUP: '/signup',
RESET_PASSWORD: '/reset-password',
JOBS: '/jobs',
MANAGE_JOBS: '/manage',

PAYMENT_HISTORY: '/manage/payments',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is manage payment code existing here ?

@VineeTagarwaL-code
Copy link
Collaborator

@Paribesh01
Copy link
Contributor Author

@VineeTagarwaL-code ok I will work on changes, also for the recruiters, should I fetch users from db with hr role ??

@VineeTagarwaL-code
Copy link
Collaborator

Answered you in dms

@Paribesh01
Copy link
Contributor Author

@VineeTagarwaL-code hr should have some relation with the company they are managing, so should i create a company model which have relation with the hr

@Paribesh01
Copy link
Contributor Author

Screen.Recording.2024-10-27.232445.mp4

@VineeTagarwaL-code done with the changes

@VineeTagarwaL-code
Copy link
Collaborator

Have you fixed that bug ? its still replicating

@Paribesh01
Copy link
Contributor Author

Screen.Recording.2024-10-29.200243.mp4

@VineeTagarwaL-code its working fine..

@VineeTagarwaL-code
Copy link
Collaborator

Screen Shot 2024-10-31 at 00 17 02
everything works, fix the mobile responsiveness of this

@Paribesh01
Copy link
Contributor Author

@VineeTagarwaL-code done
Screenshot 2024-10-31 022507

@VineeTagarwaL-code
Copy link
Collaborator

can you do the same for recruiters page ? and dont squeeze it too much just minimal space between the borders of the screen will work

@Paribesh01
Copy link
Contributor Author

Paribesh01 commented Oct 31, 2024

Screenshot 2024-10-31 114128
@VineeTagarwaL-code done

@VineeTagarwaL-code VineeTagarwaL-code merged commit 139175f into code100x:main Oct 31, 2024
1 check passed
@VineeTagarwaL-code
Copy link
Collaborator

Great pr, make sure you on post on x and tag me !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants