[pull] master from supabase:master#975
Merged
Merged
Conversation
…r leaves the tree (#46595) ## Problem Sentry [SUPABASE-APP-J7C](https://supabase.sentry.io/issues/7492405004) — `Error: Node with id=new-folder doesn't exist in the tree.` (328 events / 280 users). Crashes the SQL editor. ## Root cause `react-accessible-treeview` throws when an id is dropped from the controlled `expandedIds` prop in the same render its node leaves the tree data — its collapse effect calls `getTreeNode(data, id)` on a node that's already gone. The prior fix (`8bcb878a01`) reactively filtered `expandedIds` against the live tree, which is exactly what produces that simultaneous drop when a `new-folder` placeholder (or any expanded folder) is removed. ## Fix - Guard additions: only expand folder ids that exist in the tree. - Tolerate stale ids: pass `expandedFolderIds` as-is instead of the reactively filtered list, so we never create a "removed" delta for a node that's already gone. Stale ids are harmless — the library only inspects the add/remove delta. ## Reproduction (to verify the fix) 1. Open the SQL Editor for a project. 2. Create a folder and add a snippet into it. 3. **Expand** the folder. 4. Right-click the folder → **Delete folder** (confirm). 5. Before: the editor crashes with `Node with id=... doesn't exist in the tree.` After: no crash. Fixes SUPABASE-APP-J7C <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved stability of private snippet folder expansion in the SQL editor: auto-expansion now respects the current snippet tree state to avoid unexpected collapses or visual glitches in the folder tree. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## I have read the [CONTRIBUTING.md](https://github.com/supabase/supabase/blob/master/CONTRIBUTING.md) file. YES ## What kind of change does this PR introduce? go pages can have forms. Those forms can also submit to HubSpot and Notion, if configured properly. There appears to be a bug in the form submission that we thought we had fixed on Friday. I'm attempting to fix it here because the web developer working on this project has left the company. I can definitively rule out API keys and form UUIDs as the culprit. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Fixed CRM resolver configuration in bundled application builds to ensure proper CRM form integration across all module instances. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )