[pull] main from remotion-dev:main#842
Merged
Merged
Conversation
… to `effect-types.ts` The previous variant defined `EffectFactory` in `create-effect.ts`, which left `tsgo` unable to portably name the inferred type of factory exports in `@remotion/light-leaks`, `@remotion/starburst`, and `@remotion/effects`. Move the alias to `effect-types.ts` (already referenced by every effect package via `EffectDefinition`) and re-export from the public entry. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Mirrors the sequence eye toggle: clicking the eye next to an effect row writes `disabled: true|false` into the effect's call in source via `/api/save-effect-props`. `createEffect` auto-injects `disabled` into every effect's `schema`, so `getAllSchemaKeys` picks it up server-side and `optimisticUpdateForEffectCodeValues` round-trips it. The new field is filtered out of the expanded section's regular row list (mirroring how `hidden` is filtered for sequences), so the eye is the only control. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
… optional chain
- Restore the `{} extends P` conditional in `EffectFactory` so factories
with required params (e.g. `tint({color})`) still error on a zero-arg
call instead of silently no-opping. The TS2742 issue this avoided is
resolved separately by `EffectFactory` living in `effect-types.ts`.
- Drop the unreachable `?.` on `e.params` — `createEffect` always
defaults params to `{}`, so the optional chain never triggers.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )