[pull] main from remotion-dev:main#841
Merged
Merged
Conversation
Allows visually editing _experimentalEffects props on Sequence/HtmlInCanvas in the Studio and saving them back to the source file, mirroring the existing sequence prop editing flow. - Add `factoryName` to `EffectDefinition` and `sourceIndex` to descriptors so the Studio can map runtime descriptors back to their source array position with reorder safety. - New `EffectOverridesContext` set by `wrapInSchema`; `useMemoizedEffects` merges drag overrides > code values > runtime params per effect. - Extend `/api/subscribe-to-sequence-props` with effects[] subscriptions and effects[] statuses in the response/SSE updates. - New `/api/save-effect-props` route + `update-effect-props` codemod (verifies factoryName, updates/removes property on first-arg ObjectExpression, suppresses HMR, supports undo/redo). - New `TimelineEffectFieldRow` component dispatched from `TimelineExpandedRow` for editable effect rows in the timeline. Co-authored-by: Cursor <cursoragent@cursor.com>
Closes #7316 - Adds a `hidden` boolean field to the sequence schema, exposed as a new `hidden` prop on `<Sequence>`. When `true`, the sequence (and its children) unmount. - The Studio timeline's eye/speaker toggle now writes the `hidden` prop back to source via `save-sequence-props` instead of using the in-memory `SequenceVisibilityToggleContext`, which has been removed. - `getFieldsToShow` filters out the `hidden` field so it does not appear as a regular row in the expanded section — the toggle is the sole control. - For tracks without controls (e.g. `<Html5Audio>`, `<Html5Video>`), the toggle is hidden entirely and a spacer keeps layout consistent. Co-authored-by: Cursor <cursoragent@cursor.com>
…odePath - `packages/core/src/no-react.ts`: split type-only re-exports into `export type` so Bun does not fail at runtime with "export 'InterpolateOptions' not found". - `packages/studio-server/src/preview-server/sequence-props-watchers.ts`: resolve `absolutePath` against `remotionRoot` in the cached-nodePath branch to match the non-cached branch.
Align direct pins and lockfile with the latest release so dependency audits pick up security fixes. Co-authored-by: Cursor <cursoragent@cursor.com>
…k-to-code `@remotion/studio`: Save effect props back to source
* Add batched skills eval runs * Split batched eval run progress * Preserve skills eval log scroll position * Address batched eval review comments --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>
…#7380) * Add `hidden` prop to <Sequence>, persist via Studio timeline toggle Closes #7316 - Adds a `hidden` boolean field to the sequence schema, exposed as a new `hidden` prop on `<Sequence>`. When `true`, the sequence (and its children) unmount. - The Studio timeline's eye/speaker toggle now writes the `hidden` prop back to source via `save-sequence-props` instead of using the in-memory `SequenceVisibilityToggleContext`, which has been removed. - `getFieldsToShow` filters out the `hidden` field so it does not appear as a regular row in the expanded section — the toggle is the sole control. - For tracks without controls (e.g. `<Html5Audio>`, `<Html5Video>`), the toggle is hidden entirely and a spacer keeps layout consistent. Co-authored-by: Cursor <cursoragent@cursor.com> * Update version.ts * Update sequence.mdx * make it work for `<Video>` * add hidden field * Update TimelineListItem.tsx * Update TimelineListItem.tsx * Update index.tsx * Update HtmlInCanvas.tsx * niice * add more `hidden` fields * implement assumption * cool * Update index.tsx * Update TimelineListItem.tsx * save props mutex * Update save-prop-queue.ts * Update remotion.config.ts --------- Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )