[pull] main from remix-run:main#256
Merged
Merged
Conversation
Co-authored-by: Kamil Kuźnicki <kamil.kuznicki@silksh.pl>
* fix: handle non-regular files in dev watcher to prevent crashes The dev file watcher crashes when Unix socket files (e.g. from overmind or pm2) exist in the project root. chokidar v4 calls fs.watch() on these files, which fails on macOS with errno -102 (UNKNOWN). - Extract watcher ignore logic into an exported `isIgnoredByWatcher` function for testability - Run cheap path-based checks before the fs.statSync call to avoid unnecessary syscalls on already-ignored paths - Filter non-regular files (sockets, pipes, etc.) via fs.statSync - Add an error handler on the watcher so unexpected errors log a warning instead of crashing the process Fixes: https://github.com/RomanBaiocco/react-router-sock-repro Related: paulmillr/chokidar#1391 * chore: sign CLA * add link to chokidar github issue * don't fail create-react-router tests on deprecation warnings --------- Co-authored-by: Pedro Cattori <pcattori@gmail.com>
…esStub (#14892) Route components typed with Route.ComponentProps have more specific params and matches types. Due to TypeScript contravariance on function parameters, they were not assignable to React.ComponentType<RouteComponentProps>. Widen Component, HydrateFallback, and ErrorBoundary in StubRouteExtensions to React.ComponentType<any> so any route component can be passed without a type error. Fixes #14886 Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )