[pull] main from microsoft:main#1335
Merged
Merged
Conversation
…ross themes Co-authored-by: Copilot <copilot@github.com>
* increase debounce to reduce flickering * clean up
* Make browser toolbar more configurable * clean * test, fixes
address more image attachment optimizations + cache so we are not rerendering
make sure input switches
…by fetch (#320034) Don't include content-length header for MCP requests
…escription (#320023) * feat: add skill file parsing and enhance completion item with skill description * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…20031) * Chronicle: consolidate /chronicle standup into the skill workflow * fix test
Align chat session list action button icons and order with agents window
…ellation support (#320038) * feat: enhance session customization handling with throttling and cancellation support * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * test: enhance session customization tests with improved assertions and timeout handling * feat: add cancellation support to session plugin bundler and related tests --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Remove agent-host branch and isolation pickers (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Clarify agent-host config chip filtering (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Indent session list items by an additional 6px
* Run BG Todo Agent only if github copilot is signed in * move away from incorrectly using the `ownsAuthorization` property * add tests * fix type errors * address PR comments * fix tests
* chat: stop agent host config update loop across windows The local agent host's root config is shared across all VS Code windows. AgentHostTerminalContribution re-pushed its own managed values (defaultShell, disableCustomTerminalTool) on every rootState.onDidChange, including value changes made by *other* windows. Two windows with different terminal settings would therefore ping-pong RootConfigChanged actions forever (~8000 dispatches in 25s in the captured logs). Fix: only re-push when a managed key's *schema* first appears (host hydration), not on value-only changes from other windows. Also refactor the managed keys into a data-driven table so the schema gate, value-equality guard, dispatch, and hydration-retry are shared - adding a new managed key is now a single entry with no copy/pasted logic. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chat: rename disableCustomTerminalTool to enableCustomTerminalTool Flip the agent host root-config key polarity so the custom terminal tool is disabled by default in a natural way. `enableCustomTerminalTool` defaults to false, and since `getRootValue` returns undefined when unset and consumers compare against `true`, "unset -> disabled" now falls out naturally without touching getRootValue. The workbench-side push also drops its negation and maps 1:1 to the `chat.agentHost.customTerminalTool.enabled` setting. Note: this is a host-side schema key (not part of the versioned wire protocol), so no protocol bump. A stale `disableCustomTerminalTool` value in a persisted agent-host-config.json is simply ignored; the workbench re-pushes the new key on connect. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Re-run schema gate after async resolve in _push Addresses review feedback: after awaiting computeValue(), re-check _schemaHasKey() rather than just rootState.config existence, so a host restart / schema refresh that retracts the key can't defeat the schema gate for older / 3rd-party hosts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…lls) (#320040) * agentHost: support attaching virtual resources (untitled, notebook cells) Consolidates the agent host's permission and virtual-resource services into a single `IAgentHostResourceService` that owns the gated FS surface (`list`/`read`/`write`/`del`/`move`/`copy`/`resolve`/`mkdir`), the permission policy, and an `ITextModelService`-backed fallback for content that isn't on disk. Both the in-process local channel and the remote protocol client's reverse-RPC handler now reduce to a thin wire adapter that dispatches frames to the same service. - Adds a single `IAgentHostResourceService` (platform decorator + types, workbench implementation) replacing `IAgentHostPermissionService` and `IAgentHostVirtualResourceProvider`. - `read`, `write`, and `resolve` (stat) transparently fall back to `ITextModelService` when `IFileService` cannot satisfy the request, so attached untitled documents and notebook cells round-trip end to end. - `AgentHostClientResourceChannel` (local in-process) and `RemoteAgentHostProtocolClient._handleReverseRequest` (remote) shrink to thin adapters that translate JSON-RPC frames into service calls and surface `AgentHostResourcePermissionError` as `PermissionDenied` frames so the host's standard `resourceRequest` -> retry loop still works. - Local agent host short-circuits the permission gate (sentinel address `'local'`): the utility process already has the renderer's FS access, so gating it adds no security and would just produce unprompted denials. - `createAgentHostClientResourceConnection` now exposes `resourceRequest`, completing the local prompt/retry loop. - `agentClientUri` preserves `query` and `fragment` across the round trip and uses a `!` scheme-slot marker to faithfully round-trip opaque-path URIs such as `untitled:Untitled-1`. Fixes #319802 (Commit message generated by Copilot) * Address Copilot review and update tests for virtual-resource attachments
…y-button-border Refactor button styles for consistency
* Refactor CSS border-radius properties to use variable values - Updated various CSS files to replace hardcoded border-radius values with corresponding CSS variables for consistency and maintainability. - Adjusted border-radius for elements in openInVSCode.css, sidebarActionButton.css, style.css, auxiliaryBarPart.css, chatCompositeBar.css, panelPart.css, projectBarPart.css, mobile styles, agentFeedback styles, changes view styles, and more. - Ensured that all instances of border-radius now utilize the defined variables such as --vscode-cornerRadius-small, --vscode-cornerRadius-medium, --vscode-cornerRadius-large, etc. Co-authored-by: Copilot <copilot@github.com> * style: unify border-radius for action bar items across components Co-authored-by: Copilot <copilot@github.com> * style: update border-radius to use small variable for titlebar and session button * style: update border-radius for chat input area in phone layout --------- Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com> Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )