fix(release): ship Linux x64 PTY prebuild - #1224
Open
Altairpaca wants to merge 1 commit into
Open
Conversation
Fixes code-yeongyu#1193 Ultraworked with [omo](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: sisyphus-dev-ai <sisyphus-dev-ai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Linux x64 PTY addon is built in CI but was omitted from the published Senpi npm tarball, causing Linux installs to fall back to the pipe backend.
Root cause
The native workflow staged
native/prebuilds/<host>/...but the publish workflow did not consume the artifact, and the pack guard treated a missing host prebuild as optional.Invariant
Publish-only packaging must preserve the loader-relative
native/prebuilds/<host>/path and must fail before publication when the required Linux x64 artifact is absent. Ordinary releases and non-required platform targets retain pipe fallback.Changes
native/directory level across artifact upload and download.linux-x64during publish validation.RED -> GREEN
RED: the required-target pack test accepted a missing Linux x64 prebuild.
GREEN: packaging, staging, and workflow suites pass; 25 tests passed.
Real-surface verification
Disposable real
npm pack --dry-run --jsonQA confirmednode_modules/@earendil-works/pi-pty/native/prebuilds/linux-x64/senpi_pty.linux-x64.node; strict missing-target QA rejected publication before registry access.Regression coverage
Added the #1193 required-target cases, upload-root/download-destination path contract, optional pipe-fallback preservation, and workflow ordering assertions.
Risks / residuals
Native binary authenticity and Linux execution require the GitHub native build runner; local QA used a disposable placeholder only for tarball path verification. Full release build is host-limited because this machine runs Node 22 while the repository requires Node 24.
Non-goals
No changes to PTY runtime fallback behavior, native Rust implementation, package lockfiles, or normal release publication.
Fixes #1193