Skip to content

fix(lsp): use fileURLToPath for Windows path handling #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
code-yeongyu merged 1 commit into from
Dec 29, 2025
Merged

fix(lsp): use fileURLToPath for Windows path handling #281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions src/tools/lsp/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { extname, resolve } from "path"
import { fileURLToPath } from "node:url"
import { existsSync, readFileSync, writeFileSync } from "fs"
import { LSPClient, lspManager } from "./client"
import { findServerForExtension } from "./config"
Expand Down Expand Up @@ -41,6 +42,10 @@ export function findWorkspaceRoot(filePath: string): string {
return require("path").dirname(resolve(filePath))
}

export function uriToPath(uri: string): string {
return fileURLToPath(uri)
}

export function formatServerLookupError(result: Exclude<ServerLookupResult, { status: "found" }>): string {
if (result.status === "not_installed") {
const { server, installHint } = result
Expand Down Expand Up @@ -72,7 +77,6 @@ export function formatServerLookupError(result: Exclude<ServerLookupResult, { st
` "extensions": ["${result.extension}"]`,
` }`,
` }`,
` }`,
].join("\n")
}

Expand Down Expand Up @@ -131,13 +135,13 @@ export function formatHoverResult(result: HoverResult | null): string {

export function formatLocation(loc: Location | LocationLink): string {
if ("targetUri" in loc) {
const uri = loc.targetUri.replace("file://", "")
const uri = uriToPath(loc.targetUri)
const line = loc.targetRange.start.line + 1
const char = loc.targetRange.start.character
return `${uri}:${line}:${char}`
}

const uri = loc.uri.replace("file://", "")
const uri = uriToPath(loc.uri)
const line = loc.range.start.line + 1
const char = loc.range.start.character
return `${uri}:${line}:${char}`
Expand Down Expand Up @@ -253,7 +257,7 @@ export function formatWorkspaceEdit(edit: WorkspaceEdit | null): string {

if (edit.changes) {
for (const [uri, edits] of Object.entries(edit.changes)) {
const filePath = uri.replace("file://", "")
const filePath = uriToPath(uri)
lines.push(`File: ${filePath}`)
for (const textEdit of edits) {
lines.push(formatTextEdit(textEdit))
Expand All @@ -272,7 +276,7 @@ export function formatWorkspaceEdit(edit: WorkspaceEdit | null): string {
lines.push(`Delete: ${change.uri}`)
}
} else {
const filePath = change.textDocument.uri.replace("file://", "")
const filePath = uriToPath(change.textDocument.uri)
lines.push(`File: ${filePath}`)
for (const textEdit of change.edits) {
lines.push(formatTextEdit(textEdit))
Expand Down Expand Up @@ -370,7 +374,7 @@ export function applyWorkspaceEdit(edit: WorkspaceEdit | null): ApplyResult {

if (edit.changes) {
for (const [uri, edits] of Object.entries(edit.changes)) {
const filePath = uri.replace("file://", "")
const filePath = uriToPath(uri)
const applyResult = applyTextEditsToFile(filePath, edits)

if (applyResult.success) {
Expand All @@ -388,7 +392,7 @@ export function applyWorkspaceEdit(edit: WorkspaceEdit | null): ApplyResult {
if ("kind" in change) {
if (change.kind === "create") {
try {
const filePath = change.uri.replace("file://", "")
const filePath = uriToPath(change.uri)
writeFileSync(filePath, "", "utf-8")
result.filesModified.push(filePath)
} catch (err) {
Expand All @@ -397,8 +401,8 @@ export function applyWorkspaceEdit(edit: WorkspaceEdit | null): ApplyResult {
}
} else if (change.kind === "rename") {
try {
const oldPath = change.oldUri.replace("file://", "")
const newPath = change.newUri.replace("file://", "")
const oldPath = uriToPath(change.oldUri)
const newPath = uriToPath(change.newUri)
const content = readFileSync(oldPath, "utf-8")
writeFileSync(newPath, content, "utf-8")
require("fs").unlinkSync(oldPath)
Expand All @@ -409,7 +413,7 @@ export function applyWorkspaceEdit(edit: WorkspaceEdit | null): ApplyResult {
}
} else if (change.kind === "delete") {
try {
const filePath = change.uri.replace("file://", "")
const filePath = uriToPath(change.uri)
require("fs").unlinkSync(filePath)
result.filesModified.push(filePath)
} catch (err) {
Expand All @@ -418,7 +422,7 @@ export function applyWorkspaceEdit(edit: WorkspaceEdit | null): ApplyResult {
}
}
} else {
const filePath = change.textDocument.uri.replace("file://", "")
const filePath = uriToPath(change.textDocument.uri)
const applyResult = applyTextEditsToFile(filePath, change.edits)

if (applyResult.success) {
Expand Down