Skip to content

fix(sitemap): remove layout routes from the sitemap list #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mateussilva92 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(sitemap): remove layout routes from the sitemap list #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions src/remix/sitemap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,17 @@ const convertRemixPathToUrl = (routes: RouteManifest<Route | undefined>, route:
}

const createExtendedRoutes = (routes: RouteManifest<InternalServerRoute | undefined>) => {
return Object.values(routes).map((route) => {
return {
...route,
url: convertRemixPathToUrl(routes, route),
}
})
return Object.values(routes)
.filter((route) => {
// Filter out layouts from the routes
return route?.path !== undefined || route?.index
})
Comment on lines +38 to +42
Copy link
Copy Markdown

@frontendphil frontendphil Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't that ignore all child routes here? I think in the case of a layout route, all children should be spread into the parent for processing.

Copy link
Copy Markdown
Author

@mateussilva92 mateussilva92 Feb 26, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really. If that was the case the old code would have ignore them already since it only goes one level deep. The routes used here should come from virtual:react-router/server-build which already has all the routes flattened so none of the routes have any children, this can even be checked on the type of InternalServerRoute which even omits the children.

.map((route) => {
return {
...route,
url: convertRemixPathToUrl(routes, route),
}
})
}
const generateRemixSitemapRoutes = async ({
domain,
Expand Down