fix: TS types

[dkAndFed]

Description

Fixes the generics on some utils as the Resolver type in react-hook-form has changed.

Fixes #164

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

• Unit tests
• Consume

Checklist:

• My code follows the guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings or errors
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/forge-42/remix-hook-form@165

commit: b66a123

[AlemTuzlak]

Thank you for this, does this mean it will be possible for these utilities to infer the return type without passing in the type?

[dkAndFed]

Thank you for this, does this mean it will be possible for these utilities to infer the return type without passing in the type?

I believe passing the type was no longer necessary since version 4 of @hookform/resolvers. Edit: since 4.1.0

This PR fixes the use of types for the utils. The data should now correctly reflect the transformed values.

In the screenshot below, before the fix the preprocess would return unknown as opposed to string.

[AlemTuzlak]

@dkAndFed thank you so much for this! I was trying to,get it to work the other day and,couldn't figure out how to get it to work.

[dkAndFed]

@AlemTuzlak I haven't looked at the React specific utils, yet, but they might need to receive similar treatment. 🤔

[AlemTuzlak]

They already work, it was just the server parts!

[dkAndFed]

They already work, it was just the server parts!

Let me push some changes to the branch and you will see. Should be a minute.

Edit: @AlemTuzlak pushed the React changes as well. Now it should be aligned with react-hook-form types

[dkAndFed]

@AlemTuzlak

When do you think you will be able to merge and release this? Let me know if you need some assistance with something.

[AlemTuzlak]

Very soon!

[AlemTuzlak]

Released, again thank you so much, turns out the reason I couldn't get it to work is because I was testing it with resolvers v4 lol.