Updates .alerts.scss to be closer to BEM methodology. #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking good! I'll do a full review when I'm not so exhausted. |
|
@marineb does this require any HTML changes or does it not affect anything there? Looks like no, but wanted to be positive there are not new or renamed classes. |
|
Yes, unfortunately, no class name changes. Since they're blocked by |
joshsmith
approved these changes
Dec 6, 2016
|
Got it! Good to merge. Just rebase when you can! |
marineb
force-pushed
the
826-updates-alerts.scss-BEM-refactor
branch
from
77c505b
to
eb9c756
Compare
|
👍 Rebased to |
…cli-flash who will provide class customization in their 2.0.0.
marineb
force-pushed
the
826-updates-alerts.scss-BEM-refactor
branch
from
eb9c756
to
8860421
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates .alerts.scss to be closer to BEM methodology. Currently blocked by ember-cli-flash who will provide class customization in their 2.0.0 release. See issue on the ember-cli-flash project.
Once they do, the classes can be renamed following BEM methodology (ex: .alert--state-danger).
References
Fixes #826
Progress on: #672