Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ember-cli-meta-tags to the latest version 🚀 #1324

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

greenkeeper[bot]
Copy link

@greenkeeper greenkeeper bot commented Jun 6, 2017

Version 4.0.0 of ember-cli-meta-tags just got published.

Dependency ember-cli-meta-tags
Current Version 3.1.0
Type devDependency

The version 4.0.0 is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of ember-cli-meta-tags.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.


Commits

The new version differs by 6 commits.

  • 299d6c9 4.0.0
  • 85e54f2 Merge pull request #56 from cibernox/patch-1
  • 597a455 Remove 1.13 from ember-try. Apparently it has been broken for a while already.
  • 146208a Update readme
  • 7e71d8b Update package.json
  • 7c407e2 Update dependency on ember-cli-head

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

@begedin begedin force-pushed the greenkeeper/ember-cli-meta-tags-4.0.0 branch from 7c849f2 to 96911e6 Compare June 12, 2017 09:18
@begedin
Copy link
Contributor

begedin commented Jun 12, 2017

This fails due to what seems to be a reported issue in the ember-cli-head subdependency:

ember-fastboot/ember-cli-head#33

We should wait to see if there's any activity there before spending time trying to fix it here.

@joshsmith joshsmith force-pushed the greenkeeper/ember-cli-meta-tags-4.0.0 branch from 96911e6 to 3cf0e39 Compare October 4, 2017 01:45
@joshsmith joshsmith force-pushed the greenkeeper/ember-cli-meta-tags-4.0.0 branch from 3cf0e39 to 76d8a41 Compare November 26, 2017 09:16
@snewcomer
Copy link
Contributor

@begedin I see headTags defined in application.js route. Also see those meta tags in index.html. Is there some duplication here or am I missing something?

@begedin begedin force-pushed the greenkeeper/ember-cli-meta-tags-4.0.0 branch from 76d8a41 to 2fae438 Compare December 11, 2017 07:06
@begedin begedin force-pushed the greenkeeper/ember-cli-meta-tags-4.0.0 branch from 2fae438 to 14002f0 Compare December 11, 2017 07:08
@joshsmith
Copy link
Contributor

@begedin ping again on this question.

@begedin
Copy link
Contributor

begedin commented Dec 12, 2017

@joshsmith @snewcomer

I'm not the one who worked on it initially, so I'm not sure. My guess would be, the index.html ones are the default to fall back on, while each route would end up dynamically setting their own.

We only do it in the app route right now, and from what I can tell, they're near-identical, to those in index.html, so technically, I guess we don't really need ember-cli-meta-tags yet, maybe.

We presumably would end up needing them eventually, though, since we'd like different tags on project pages, for example.

greenkeeper bot added a commit that referenced this pull request Jun 26, 2018
@greenkeeper
Copy link
Author

greenkeeper bot commented Jun 26, 2018

Version 4.1.0 just got published.

Update to this version instead 🚀

Commits

The new version differs by 21 commits.

There are 21 commits in total.

See the full diff

greenkeeper bot added a commit that referenced this pull request Jun 26, 2018
@greenkeeper
Copy link
Author

greenkeeper bot commented Jun 26, 2018

Version 5.0.0 just got published.

Update to this version instead 🚀

Commits

The new version differs by 2 commits.

  • 1eca975 Preparations to publish 5.0.0 (#73)
  • 07c2d37 update head to 0.4.1 (#71)

See the full diff

greenkeeper bot added a commit that referenced this pull request Aug 3, 2018
@greenkeeper
Copy link
Author

greenkeeper bot commented Aug 3, 2018

Version 5.1.0 just got published.

Update to this version instead 🚀

Commits

The new version differs by 8 commits.

See the full diff

greenkeeper bot added a commit that referenced this pull request Jan 18, 2019
@greenkeeper
Copy link
Author

greenkeeper bot commented Jan 18, 2019

Update to this version instead 🚀

Commits

The new version differs by 2 commits.

See the full diff

greenkeeper bot added a commit that referenced this pull request Jan 21, 2019
@greenkeeper
Copy link
Author

greenkeeper bot commented Jan 21, 2019

Update to this version instead 🚀

Commits

The new version differs by 2 commits.

See the full diff

greenkeeper bot added a commit that referenced this pull request Apr 7, 2020
@greenkeeper
Copy link
Author

greenkeeper bot commented Apr 7, 2020

Update to this version instead 🚀

Commits

The new version differs by 16 commits.

There are 16 commits in total.

See the full diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants