-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ember-cli-meta-tags to the latest version 🚀 #1324
base: develop
Are you sure you want to change the base?
Conversation
7c849f2
to
96911e6
Compare
This fails due to what seems to be a reported issue in the ember-cli-head subdependency: ember-fastboot/ember-cli-head#33 We should wait to see if there's any activity there before spending time trying to fix it here. |
96911e6
to
3cf0e39
Compare
3cf0e39
to
76d8a41
Compare
@begedin I see |
76d8a41
to
2fae438
Compare
2fae438
to
14002f0
Compare
@begedin ping again on this question. |
I'm not the one who worked on it initially, so I'm not sure. My guess would be, the We only do it in the app route right now, and from what I can tell, they're near-identical, to those in We presumably would end up needing them eventually, though, since we'd like different tags on project pages, for example. |
Version 4.1.0 just got published.Update to this version instead 🚀 CommitsThe new version differs by 21 commits.
There are 21 commits in total. See the full diff |
Version 5.0.0 just got published. |
Version 5.1.0 just got published.Update to this version instead 🚀 CommitsThe new version differs by 8 commits.
See the full diff |
|
|
Update to this version instead 🚀 CommitsThe new version differs by 16 commits.
There are 16 commits in total. See the full diff |
Version 4.0.0 of ember-cli-meta-tags just got published.
The version 4.0.0 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of ember-cli-meta-tags.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Commits
The new version differs by 6 commits.
299d6c9
4.0.0
85e54f2
Merge pull request #56 from cibernox/patch-1
597a455
Remove 1.13 from ember-try. Apparently it has been broken for a while already.
146208a
Update readme
7e71d8b
Update package.json
7c407e2
Update dependency on ember-cli-head
See the full diff
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴