feat: add configurable double-tap seek with ytp-seek visual feedback#4168
Open
heidevary wants to merge 4 commits into
Open
feat: add configurable double-tap seek with ytp-seek visual feedback#4168heidevary wants to merge 4 commits into
heidevary wants to merge 4 commits into
Conversation
- Add touchend listener to shortcuts.js for double-tap detection on player - Support 3 modes: default, fixed distance, progressive distance - Use player.seekTo() and toggle ytp-seek-* visual classes - Add menu controls, i18n labels, and Jest tests Closes code-charity#4132
- Only add new i18n keys without reformatting existing entries - Remove version numbers from code comments
The touchend handler was calling preventDefault() on all touch events in the player area, which broke play/pause, fullscreen, and settings buttons. Added a check to skip taps on .ytp-chrome-bottom, .ytp-button, and other control elements.
Author
Self-Check FixAfter reviewing my own PR, I found and fixed one issue:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements configurable double-tap seek distances for touch devices, addressing issue #4132.
This PR follows the maintainer's guidance from the issue discussion:
shortcuts.js- thetouchendlistener is integrated into the existingshortcutsListenerssystemytp-seek-*visual classes modified through the DOM - togglesytp-seek-forward-bump/ytp-seek-backward-bumpon the player element, and triggers YouTube'sytp-doubletap-uioverlayplayer.seekTo()- as the maintainer specified, notseekBy()event.preventDefault()+event.stopPropagation()- prevents YouTube's default double-tap behavior when custom mode is activeFeatures
Three seek modes (as requested in the issue):
Changes
shortcuts.jstouchendlistener toshortcutsListeners,doubleTapSeek()function, modifyshortcutsInit()menu/skeleton-parts/player.js_locales/en/messages.jsontests/unit/double-tap-seek.test.js/claim #4132