Skip to content

Update stylelint to V16.26.1#529

Merged
stefanvacareanu7 merged 10 commits into
masterfrom
bump_stylelint_v17
Jun 11, 2026
Merged

Update stylelint to V16.26.1#529
stefanvacareanu7 merged 10 commits into
masterfrom
bump_stylelint_v17

Conversation

@stefanvacareanu7

@stefanvacareanu7 stefanvacareanu7 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

the v17 is bringing some internal failures over the tests, risking massive silent failures for customers if updated like this. For the moment, it is being updated to latest v16 and to the latest side dependencies.

@stefanvacareanu7 stefanvacareanu7 requested a review from a team as a code owner June 10, 2026 09:32
@codacy-production

codacy-production Bot commented Jun 10, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 duplication

Metric Results
Duplication 0

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates Stylelint documentation and configuration metadata to align with the upgrade to version 17.13.0, introducing several new rules and documenting message arguments for existing ones. The review feedback highlights a few errors in the updated documentation: an incorrect configuration key ("ignoreProperties" instead of "ignoreMediaFeatureNames") in the media feature vendor prefix rule, the use of standard rule names instead of SCSS-specific ones in the SCSS class pattern documentation, and an incomplete title fragment in "description.json".

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

{
"media-feature-name-no-vendor-prefix": [
true,
{ "ignoreProperties": ["-webkit-min-device-pixel-ratio", "/^-o/"] }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The secondary option for this rule is ignoreMediaFeatureNames, but the configuration example incorrectly uses ignoreProperties. This will cause the option to be ignored or fail validation.

Suggested change
{ "ignoreProperties": ["-webkit-min-device-pixel-ratio", "/^-o/"] }
{ "ignoreMediaFeatureNames": ["-webkit-min-device-pixel-ratio", "/^-o/"] }


```json
{
"selector-class-pattern": "foo-[a-z]+"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The configuration example uses the standard rule name selector-class-pattern instead of the SCSS plugin rule name scss/selector-class-pattern. This will configure the wrong rule in stylelint.

Suggested change
"selector-class-pattern": "foo-[a-z]+"
"scss/selector-class-pattern": "foo-[a-z]+"


```json
{
"selector-class-pattern": ["^[A-Z]+$", { "resolveNestedSelectors": true }]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The configuration example uses the standard rule name selector-class-pattern instead of the SCSS plugin rule name scss/selector-class-pattern. This will configure the wrong rule in stylelint.

Suggested change
"selector-class-pattern": ["^[A-Z]+$", { "resolveNestedSelectors": true }]
"scss/selector-class-pattern": ["^[A-Z]+$", { "resolveNestedSelectors": true }]

} ]
}, {
"patternId" : "scss_dollar-variable-no-missing-interpolation",
"title" : "This rule flags four situations in which Sass variables require interpolation:",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The title for scss_dollar-variable-no-missing-interpolation has been changed to a sentence fragment ending with a colon. It should be a concise, descriptive title instead.

Suggested change
"title" : "This rule flags four situations in which Sass variables require interpolation:",
"title" : "Disallow Sass variables that are used without interpolation in required scenarios.",

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades Stylelint to version 17.13.0 and updates the associated rule documentation and metadata. The codebase currently aligns with Codacy quality standards.

The primary issues identified concern technical errors in the documentation examples: incorrect option keys in the media feature documentation and missing rule prefixes in SCSS-specific rule examples. These should be addressed to ensure the documentation correctly guides users. Additionally, the PR description is currently empty, which makes it difficult to track the context or specific breaking changes addressed in this update.

About this PR

  • The PR description is empty. Please provide context for the upgrade or a summary of addressed breaking changes to aid future maintainability.

Test suggestions

  • Verify Stylelint version 17.13.0 is specified in package.json
  • Verify documentation for new 'display-notation' rule is added
  • Verify documentation for new 'property-layout-mappings' rule is added
  • Verify documentation for new 'relative-selector-nesting-notation' rule is added
  • Verify documentation for new 'selector-no-deprecated' rule is added
  • Verify patterns.json metadata is updated to version 17.13.0

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

{
"media-feature-name-no-vendor-prefix": [
true,
{ "ignoreProperties": ["-webkit-min-device-pixel-ratio", "/^-o/"] }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM RISK

The option key used in this example is incorrect. It should be ignoreMediaFeatureNames to match the rule's schema and the provided context.

Suggested change
{ "ignoreProperties": ["-webkit-min-device-pixel-ratio", "/^-o/"] }
{ "ignoreMediaFeatureNames": ["-webkit-min-device-pixel-ratio", "/^-o/"] }


```json
{
"selector-class-pattern": ["^[A-Z]+$", { "resolveNestedSelectors": true }]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ LOW RISK

Suggestion: The rule name in the example should use the scss/ prefix.

Suggested change
"selector-class-pattern": ["^[A-Z]+$", { "resolveNestedSelectors": true }]
"scss/selector-class-pattern": ["^[A-Z]+$", { "resolveNestedSelectors": true }]

```json
{
"selector-class-pattern": "foo-[a-z]+"
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ LOW RISK

Suggestion: The rule name in the example should include the scss/ prefix to correctly identify it as the plugin rule.

Suggested change
}
"scss/selector-class-pattern": "foo-[a-z]+"

}, {
"patternId" : "scss_dollar-variable-no-missing-interpolation",
"title" : "This rule flags four situations in which Sass variables require interpolation:",
"parameters" : [ {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ LOW RISK

Nitpick: The title is phrased as a sentence instead of a concise summary. It is recommended to use a shorter, descriptive phrase.

Suggested change
"parameters" : [ {
"title" : "Disallow Sass variables that are used without interpolation with CSS features that use custom identifiers.",

@stefanvacareanu7 stefanvacareanu7 changed the title Update stylelint to V17 Update stylelint to V16.26.1 Jun 10, 2026
@stefanvacareanu7 stefanvacareanu7 merged commit aa2d07e into master Jun 11, 2026
5 checks passed
@stefanvacareanu7 stefanvacareanu7 deleted the bump_stylelint_v17 branch June 11, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants