Merge pull request #156 from cocopon/refactor-comments

Refactor comments
cocopon · Feb 24, 2021 · 800cdb3 · 800cdb3
2 parents fd03ff0 + 7218638
commit 800cdb3
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 14 deletions.
diff --git a/lib/plugin/blade/common/model/blade-rack.ts b/lib/plugin/blade/common/model/blade-rack.ts
@@ -106,13 +106,9 @@ export class BladeRack {
 		bc.blade.emitter.on('change', this.onListItemLayout_);
 
 		if (bc instanceof InputBindingController) {
-			const emitter = bc.binding.emitter;
-			// TODO: Find more type-safe way
-			(emitter.on as any)('change', this.onItemInputChange_);
+			bc.binding.emitter.on('change', this.onItemInputChange_);
 		} else if (bc instanceof MonitorBindingController) {
-			const emitter = bc.binding.emitter;
-			// TODO: Find more type-safe way
-			emitter.on('update', this.onItemMonitorUpdate_);
+			bc.binding.emitter.on('update', this.onItemMonitorUpdate_);
 		} else if (bc instanceof FolderController) {
 			bc.folder.emitter.on('change', this.onItemFolderFold_);
 

diff --git a/lib/plugin/common/binding/input-test.ts b/lib/plugin/common/binding/input-test.ts
@@ -30,7 +30,6 @@ describe(InputBinding.name, () => {
 		};
 		const target = new BindingTarget(obj, 'foo');
 		const value = new Value(0);
-		// tslint:disable-next-line:no-unused-expression
 		new InputBinding({
 			reader: numberFromUnknown,
 			target: target,
@@ -53,7 +52,6 @@ describe(InputBinding.name, () => {
 		const obj: {foo?: string} = {};
 		const target = new BindingTarget(obj, 'foo');
 		const value = new Value(0);
-		// tslint:disable-next-line:no-unused-expression
 		new InputBinding({
 			reader: numberFromUnknown,
 			target: target,

diff --git a/lib/plugin/common/binding/monitor-test.ts b/lib/plugin/common/binding/monitor-test.ts
@@ -33,7 +33,6 @@ describe(MonitorBinding.name, () => {
 		const target = new BindingTarget(obj, 'foo');
 		const value = new Value([0] as Buffer<number>);
 		const ticker = new ManualTicker();
-		// tslint:disable-next-line:no-unused-expression
 		new MonitorBinding({
 			reader: numberFromUnknown,
 			target: target,
@@ -66,7 +65,6 @@ describe(MonitorBinding.name, () => {
 		const target = new BindingTarget(obj, 'foo');
 		const value = new Value([0] as Buffer<number>);
 		const ticker = new ManualTicker();
-		// tslint:disable-next-line:no-unused-expression
 		new MonitorBinding({
 			reader: numberFromUnknown,
 			target: target,

diff --git a/lib/plugin/input-bindings/color/converter/color-string-test.ts b/lib/plugin/input-bindings/color/converter/color-string-test.ts
@@ -169,7 +169,6 @@ describe('StringColorParser', () => {
 		});
 	});
 
-	// tslint:disable:object-literal-sort-keys
 	[
 		{
 			input: '#112233',

diff --git a/lib/plugin/input-bindings/color/model/color.ts b/lib/plugin/input-bindings/color/model/color.ts
@@ -135,14 +135,11 @@ export class Color {
 
 	public toRgbaObject(): RgbaColorObject {
 		const rgbComps = this.getComponents('rgb');
-
-		// tslint:disable:object-literal-sort-keys
 		return {
 			r: rgbComps[0],
 			g: rgbComps[1],
 			b: rgbComps[2],
 			a: rgbComps[3],
 		};
-		// tslint:enable:object-literal-sort-keys
 	}
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -169,7 +169,6 @@ describe('StringColorParser', () => { @@
     		});
     	});
-    	// tslint:disable:object-literal-sort-keys
     	[
     		{
     			input: '#112233',
@@ Expand Down @@