Skip to content

fix: reclaim clone-source copies no pod on the node clones from #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CMGS merged 1 commit into from
Sep 29, 2026
Merged

fix: reclaim clone-source copies no pod on the node clones from #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion provider/cocoon/gc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,18 @@ func (p *Provider) reclaimLocalSnapshots(ctx context.Context) {
p.removeSnapshotDetached(ctx, s.Name)
continue
}
if _, _, verifyErr := p.verifyLocalSnapshot(ctx, vmName, &s); errors.Is(verifyErr, errStaleLocalSnapshot) {
if strings.Contains(vmName, ":") {
logger.Infof(ctx, "reclaim local snapshot %s: no pod on this node clones from it", s.Name)
p.removeSnapshotDetached(ctx, s.Name)
continue
}
_, _, verifyErr := p.verifyLocalSnapshot(ctx, vmName, &s)
switch {
case errors.Is(verifyErr, errStaleLocalSnapshot):
logger.Infof(ctx, "reclaim local snapshot %s: %v", s.Name, verifyErr)
p.removeLocalSnapshots(ctx, vmName)
case verifyErr != nil:
logger.Warnf(ctx, "keep local snapshot %s: verify against the registry: %v", s.Name, verifyErr)
}
}
}
Expand Down
11 changes: 11 additions & 0 deletions provider/cocoon/gc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@ package cocoon
import (
"errors"
"slices"
"strings"
"testing"

"github.com/cocoonstack/cocoon-common/meta"
"github.com/cocoonstack/cocoon-common/oci"
"github.com/cocoonstack/cocoon-common/ociutil"
"github.com/cocoonstack/vk-cocoon/vm"
)

Expand All @@ -15,6 +17,11 @@ func TestTheReclaimerDropsOnlyWhatNoPodOnTheNodeCanWakeFrom(t *testing.T) {
importName := vmName + meta.HibernateImportSuffix
self := meta.VMSpec{VMName: vmName}
cloner := meta.VMSpec{VMName: "vk-ns-clone-0-9a1f3c", Image: vmName}
taggedCopy := vmName + ":v2"
tagCloner := meta.VMSpec{VMName: "vk-ns-clone-0-9a1f3c", Image: taggedCopy}
digestRef := vmName + "@sha256:" + strings.Repeat("ab", 32)
digestCopy := localSnapshotName(ociutil.ParseRef(digestRef))
digestCloner := meta.VMSpec{VMName: "vk-ns-clone-0-9a1f3c", Image: digestRef}
tests := []struct {
name string
local string
Expand All @@ -32,6 +39,10 @@ func TestTheReclaimerDropsOnlyWhatNoPodOnTheNodeCanWakeFrom(t *testing.T) {
{"an import no pod on this node wakes", importName, meta.VMSpec{}, newWakeVerifyRegistry(t, "SNAP-1"), []string{importName}},
{"an import a pod on this node wakes", importName, self, newWakeVerifyRegistry(t, "SNAP-1"), nil},
{"no registry configured", vmName, meta.VMSpec{}, nil, nil},
{"a tagged clone-source copy no pod clones from", taggedCopy, meta.VMSpec{}, registryDown(t), []string{taggedCopy}},
{"a tagged clone-source copy a pod clones from", taggedCopy, tagCloner, registryDown(t), nil},
{"a digest clone-source copy no pod clones from", digestCopy, meta.VMSpec{}, registryDown(t), []string{digestCopy}},
{"a digest clone-source copy a pod clones from", digestCopy, digestCloner, registryDown(t), nil},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
Expand Down
Loading