Repository navigation
admission: accept a digest-pinned clone-mode image - #28
Merged
Merged
Conversation
cloneImageError relied on cocoon-common's IsRelativeRef, which rejected every repo@digest, so a CocoonSet agent or clone toolbox pinned by digest was refused before it reached vk-cocoon and no retry could fix it. cocoon-common#37 teaches ParseRef and IsRelativeRef the digest form; this bumps to it and says so in the rejection message and docs/validation.md. Malformed digests, registry ports and a tag with a digest stay rejected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
cloneImageErrorvalidates clone-mode images with cocoon-common'sociutil.IsRelativeRef, which rejected everyrepo@digest. A CocoonSet whose agent or clone toolbox is pinned by digest was refused at admission, before vk-cocoon, and no retry could fix it. Found in review of cocoonstack/vk-cocoon#118, which fixes the vk-cocoon side of digest clone sources.Fix
v0.3.7-0.20260928165838-565b61e948a2), whereParseRefsplitsrepo@digestandIsRelativeRefaccepts a lowercase repo with asha256/sha512digest of the right length.docs/validation.mdstates the grammar.Tests
accepts clone-mode digest image(agent) andaccepts clone-mode toolbox digest image.ubuntu@sha256:deadbeefcase stays a rejection, renamed torejects clone-mode malformed digest image.Order
cocoon-common#37 first, then re-pin this PR to the merge commit or tag, then merge. vk-cocoon#118 re-pins to the same commit.
Gates
make lint0 issues on linux and darwin,make fmt-checkclean,asl ./...clean on both GOOS,go test -race ./...green (GOWORK=off). Not run on hardware.