fix(ci): build Docker image from local source; add test-dispatch#136
Merged
fix(ci): build Docker image from local source; add test-dispatch#136
Conversation
- Install cocoindex-code from the checked-out source tree (same build-arg used by local E2E tests) instead of pulling from PyPI. Avoids a race where the just-published wheel hadn't propagated to PyPI's CDN when publish-docker started, and ensures the image matches the tagged commit byte-for-byte. - Add a `test_docker` workflow_dispatch input so registry credentials (Docker Hub + GHCR) can be verified before the next release without having to cut one. Dispatch pushes `:test` only; release pushes `:latest` + `:<version>`. - Drop the needs: publish-to-pypi dependency — with local-source install we no longer need PyPI to be up-to-date first.
This was referenced Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #135. The Docker publish step failed on the v0.2.24 release (https://github.com/cocoindex-io/cocoindex-code/actions/runs/24421462667/job/71344624894) — the build pulled
cocoindex-code[default]from PyPI right after the PyPI publish completed, before the new wheel had propagated to PyPI's CDN, so the resulting install was missing thecccentry point added in this release.Summary
cocoindex-codefrom the checked-out source tree viaCCC_INSTALL_SPEC=/ccc-src[default](same build-arg the local E2E tests use). Image matches the tagged commit byte-for-byte; no PyPI race.needs: publish-to-pypi— with the local-source install we no longer depend on PyPI being up-to-date first. Docker publish can now run in parallel with PyPI publish.test_dockerworkflow_dispatch input so credentials (Docker Hub + GHCR) can be verified without cutting a release. Dispatch pushes:testonly; real releases still push:latest+:<version>.Test plan
test_docker=trueonce this lands — confirms both registry logins work and the build succeeds against the mergedmain. The resulting:testtag won't interfere with real releases.🤖 Generated with Claude Code