pkg/cli (tsdump): add interval to metrics before uploading #147316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjunmahishi
requested review from
alyshanjahani-crl,
aa-joshi and
Abhinav1299
and removed request for
a team
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=95b789b1d594ac6b74f377aa7555d8d98d63240d&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
arjunmahishi
changed the title
|
This change is |
arjunmahishi
force-pushed
the
tsdump-interval
branch
from
3226165 to
15e4f0c
Compare
arjunmahishi
force-pushed
the
tsdump-interval
branch
3 times, most recently
from
2a618b4 to
9ea2b10
Compare
aa-joshi
approved these changes
May 30, 2025
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @Abhinav1299 and @alyshanjahani-crl)
-- commits line 15 at r1:
It would be good if we can add context about adding time interval in DD upload requests.
This commit introduces a new interval field to the DatadogSeries struct, representing the interval in seconds. The interval is encoded in the keys used to store metrics in the TSDB. It can be either 10s or 1800s (30min). Recent metrics use a 10s interval, while older metrics (typically 10 days or older) that have been rolled up use a 30min interval. Including the interval is crucial because Datadog relies on this information to accurately interpret and display metrics. Without the interval, Datadog may assume a default value, leading to inconsistent or misleading visualizations, especially when zooming in or out on time-series graphs. This behavior can result in discrepancies in reported values across different zoom levels, as Datadog aggregates data differently based on the assumed interval.  Additionally, this commit adds a new end-to-end test for the tsdump-datadog upload flow. This test runs the tsdump command as a separate process, simulating user behavior, and mocks the Datadog API server to verify the upload functionality and data transformation logic. Part of: CC-32614 Release note: None
arjunmahishi
force-pushed
the
tsdump-interval
branch
from
9ea2b10 to
4adf237
Compare
arjunmahishi
commented
May 30, 2025
There was a problem hiding this comment.
Reviewable status:
Previously, aa-joshi (Akshay Joshi) wrote…
It would be good if we can add context about adding time interval in DD upload requests.
Done
|
TFTR! |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new interval field to the DatadogSeries struct, representing the interval in seconds.
The interval is encoded in the keys used to store metrics in the TSDB. It can be either 10s or 1800s (30min). Recent metrics use a 10s interval, while older metrics (typically 10 days or older) that have been rolled up use a 30min interval.
Including the interval is crucial because Datadog relies on this information to accurately interpret and display metrics. Without the interval, Datadog may assume a default value, leading to inconsistent or misleading visualizations, especially when zooming in or out on time-series graphs. This behavior can result in discrepancies in reported values across different zoom levels, as Datadog aggregates data differently based on the assumed interval. 
Additionally, this commit adds a new end-to-end test for the tsdump-datadog upload flow. This test runs the tsdump command as a separate process, simulating user behavior, and mocks the Datadog API server to verify the upload functionality and data transformation logic.
Part of: CC-32614
Release note: None