Merge #106917 #106941

106917: roachtest: delete synctest r=RaduBerinde,itsbilal a=sumeerbhola

This test has been skipped since May 2020, because Pebble code is written to crash on an error when writing to the MANIFEST and the WAL, since it is not viable to continue. Additionally, there were problems with hangs due to charybdefs returning EAGAIN (which have since been fixed).

We are deleting this now since:
- The purpose of this test is to test that Pebble does not lose data due to filesystem errors. It does so in a cruder manner than Pebble's strict MemFS based testing (which came later). Given the existence of the latter, there is no good reason to retain this test.

- Working around charybdefs flakiness (see #102492), and Pebble's failstop-on-error behavior is not worth the initial and ongoing maintenance effort.

Epic: none

Fixes: #48603

Release note: None

106941: build: use pnpm for cluster-ui auto-publishing r=nathanstilwell,rickystewart a=sjbarag

The pkg/ui/ tree recently switched to pnpm (from yarn) for package management [1], but the GitHub workflow to automatically publish new versions of pkg/ui/workspaces/cluster-ui wasn't updated to align with that. Use pnpm for dependency management when auto-publishing canary and full-release versions of cluster-ui.

Release note: None
Epic: None

Co-authored-by: sumeerbhola <[email protected]>
Co-authored-by: Sean Barag <[email protected]>

.github/workflows/cluster-ui-release-next.yml

@@ -28,14 +28,18 @@ jobs:
         path: ~/.cache/bazel
         key: ${{ runner.os }}-bazel-cache
 
+    - uses: pnpm/action-setup@v2
+      with:
+        version: 8
+
     - name: Setup NodeJS
       uses: actions/setup-node@v3
       with:
         node-version: 16
         registry-url: 'https://registry.npmjs.org'
         always-auth: true
-        cache: 'yarn'
-        cache-dependency-path: pkg/ui/workspaces/cluster-ui/yarn.lock
+        cache: 'pnpm'
+        cache-dependency-path: 'pkg/ui/pnpm-lock.yaml'
       env:
         NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
 
@@ -59,10 +63,10 @@ jobs:
     - name: Build Cluster UI
       if: steps.version-check.outputs.published == 'no'
       run: |
-        yarn install --frozen-lockfile
+        pnpm install --frozen-lockfile
         bazel build //pkg/ui/workspaces/db-console/src/js:crdb-protobuf-client
         cp ../../../../_bazel/bin/pkg/ui/workspaces/db-console/src/js/protos.* ../db-console/src/js/
-        yarn build
+        pnpm build
 
     - name: Create version tag and push
       if: steps.version-check.outputs.published == 'no'

.github/workflows/cluster-ui-release.yml

@@ -6,7 +6,6 @@ on:
       - 'release-*'
     paths:
       - 'pkg/ui/workspaces/cluster-ui/**/*.tsx?'
-      - 'pkg/ui/workspaces/cluster-ui/yarn.lock'
       - 'pkg/ui/workspaces/cluster-ui/package.json'
 
 jobs:
@@ -28,14 +27,18 @@ jobs:
         path: ~/.cache/bazel
         key: ${{ runner.os }}-bazel-cache
 
+    - uses: pnpm/action-setup@v2
+      with:
+        version: 8
+
     - name: Setup NodeJS
       uses: actions/setup-node@v3
       with:
         node-version: 16
         registry-url: 'https://registry.npmjs.org'
         always-auth: true
-        cache: 'yarn'
-        cache-dependency-path: pkg/ui/workspaces/cluster-ui/yarn.lock
+        cache: 'pnpm'
+        cache-dependency-path: 'pkg/ui/pnpm-lock.yaml'
       env:
         NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
 
@@ -64,10 +67,10 @@ jobs:
     - name: Build Cluster UI
       if: steps.version-check.outputs.published == 'no'
       run: |
-        yarn install --frozen-lockfile
+        pnpm install --frozen-lockfile
         bazel build //pkg/ui/workspaces/db-console/src/js:crdb-protobuf-client
         cp ../../../../_bazel/bin/pkg/ui/workspaces/db-console/src/js/protos.* ../db-console/src/js/
-        yarn build
+        pnpm build
 
     - name: Create version tag and push
       if: steps.version-check.outputs.published == 'no'

pkg/cli/debug_synctest.go

@@ -30,6 +30,11 @@ import (
 	"github.com/spf13/cobra"
 )
 
+// TODO(sumeer): consider deleting this command, now that it is no longer
+// exercised by the synctest roachtest (which has been deleted). We will need
+// to confirm that users of CockroachDB are not running it as part of their
+// testing.
+
 var debugSyncTestCmd = &cobra.Command{
 	Use:   "synctest <empty-dir> <nemesis-script>",
 	Short: "Run a log-like workload that can help expose filesystem anomalies",

pkg/cmd/roachtest/tests/BUILD.bazel

@@ -152,7 +152,6 @@ go_library(
         "sqlsmith.go",
         "sstable_corruption.go",
         "status_server.go",
-        "synctest.go",
         "sysbench.go",
         "tlp.go",
         "tombstones.go",

pkg/cmd/roachtest/tests/registry.go

@@ -133,7 +133,6 @@ func RegisterTests(r registry.Registry) {
 	registerSecure(r)
 	registerSequelize(r)
 	registerSlowDrain(r)
-	registerSyncTest(r)
 	registerSysbench(r)
 	registerTLP(r)
 	registerTPCC(r)