Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Compare XML instead of produces bytes #70

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Conversation

SchoolGuy
Copy link
Member

Fixes #69

@SchoolGuy SchoolGuy requested a review from a team October 1, 2024 07:41
Copy link

codacy-production bot commented Oct 1, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+1.92% (target: -1.00%) 81.82% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a2fc56e) 3232 1874 57.98%
Head commit (2164f74) 3245 (+13) 1944 (+70) 59.91% (+1.92%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#70) 33 27 81.82%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Contributor

@tiltingpenguin tiltingpenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SchoolGuy
Copy link
Member Author

This approach doesn't work at the moment since there is no concept of "map" available so it complains about unmatching elements.

@SchoolGuy SchoolGuy marked this pull request as draft October 1, 2024 12:12
@SchoolGuy SchoolGuy marked this pull request as ready for review October 2, 2024 12:11
testing.go Outdated Show resolved Hide resolved
testing.go Outdated Show resolved Hide resolved
testing.go Outdated Show resolved Hide resolved
@SchoolGuy SchoolGuy merged commit c34bc43 into main Oct 7, 2024
20 checks passed
@SchoolGuy SchoolGuy deleted the fix/compare-xml branch October 7, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Allow comparison of two XML files that send maps
2 participants