Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remaining XML-RPC endpoints #20

Merged
merged 15 commits into from
May 23, 2024
Merged

Add remaining XML-RPC endpoints #20

merged 15 commits into from
May 23, 2024

Conversation

SchoolGuy
Copy link
Member

@SchoolGuy SchoolGuy commented May 20, 2024

I am not sure if this adds all remaining endpoints but it adds the biggest chunk of them.

This should contain tests for most of the endpoints that are being communicated with.

This PR currently doesn't touch the topic of resolved items and exposing this conveniently. I think this would blow up the scope of this PR too much.

Fixes #4

@SchoolGuy SchoolGuy added this to the 0.5.0 milestone May 20, 2024
@SchoolGuy SchoolGuy force-pushed the tests/add-multiple branch 3 times, most recently from c057711 to 066a8c5 Compare May 20, 2024 14:51
Copy link

@ByteOtter ByteOtter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side it looks good - though my Go is not the best so you may want to wait for another review :)

I also marked some todos in regards to documentation for you, take a look if you have time but as long as the functionality works this is fine to merge.

distro.go Show resolved Hide resolved
distro.go Show resolved Hide resolved
event.go Show resolved Hide resolved
event.go Show resolved Hide resolved
item.go Show resolved Hide resolved
resource.go Outdated Show resolved Hide resolved
Copy link
Contributor

@tiltingpenguin tiltingpenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are missing the tests for item.go

event.go Outdated Show resolved Hide resolved
event.go Outdated Show resolved Hide resolved
item.go Outdated Show resolved Hide resolved
item.go Outdated Show resolved Hide resolved
item.go Show resolved Hide resolved
menu.go Outdated Show resolved Hide resolved
menu.go Outdated Show resolved Hide resolved
mgmtclass.go Outdated Show resolved Hide resolved
file.go Outdated Show resolved Hide resolved
file.go Outdated Show resolved Hide resolved
Copy link
Contributor

@tiltingpenguin tiltingpenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only checked the diff between the last version and this one but apart from one mistake this LGTM

image.go Outdated Show resolved Hide resolved
Copy link

@ByteOtter ByteOtter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after you fix tiltingpenguin's comments.

Copy link
Contributor

@tiltingpenguin tiltingpenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SchoolGuy SchoolGuy merged commit b57151e into main May 23, 2024
10 checks passed
@SchoolGuy SchoolGuy deleted the tests/add-multiple branch May 23, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Missing API Endpoints for a lot of things
3 participants