-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remaining XML-RPC endpoints #20
Conversation
c057711
to
066a8c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my side it looks good - though my Go is not the best so you may want to wait for another review :)
I also marked some todos in regards to documentation for you, take a look if you have time but as long as the functionality works this is fine to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are missing the tests for item.go
This commit adds a base struct and adds common generic methods the client. Already existing methods were moved into the item.go file.
This adds the abstract base struct for the Resource class in the backend. It has no dedicated XML-RPC methods.
066a8c5
to
edaffc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only checked the diff between the last version and this one but apart from one mistake this LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after you fix tiltingpenguin's comments.
edaffc0
to
5c4e45b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I am not sure if this adds all remaining endpoints but it adds the biggest chunk of them.
This should contain tests for most of the endpoints that are being communicated with.
This PR currently doesn't touch the topic of resolved items and exposing this conveniently. I think this would blow up the scope of this PR too much.
Fixes #4