Skip to content

Fix cell allocation with spread instances#44

Merged
mchristianl merged 1 commit intomainfrom
fix-spread-numa-cell-allocation
Feb 6, 2026
Merged

Fix cell allocation with spread instances#44
mchristianl merged 1 commit intomainfrom
fix-spread-numa-cell-allocation

Conversation

@PhilippMatthes
Copy link
Member

Libvirt instances can be spread across multiple cells. In this case, we want to only add the actual allocation of the instance to each cell, and not the total allocation. The implementation assumes that, when instances are spread across multiple cells, they allocate their resources evenly.

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/kvm-node-agent/internal/libvirt 40.00% (+0.57%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/kvm-node-agent/internal/libvirt/libvirt.go 71.50% (+0.58%) 200 (+4) 143 (+4) 57 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/cobaltcore-dev/kvm-node-agent/internal/libvirt/libvirt_test.go

@mchristianl mchristianl merged commit d65be5e into main Feb 6, 2026
6 checks passed
@PhilippMatthes PhilippMatthes deleted the fix-spread-numa-cell-allocation branch February 6, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants