Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gometalinter installer for all golang syntax checkers #2596

Open
jayvdb opened this issue Jul 9, 2018 · 2 comments
Open

Use gometalinter installer for all golang syntax checkers #2596

jayvdb opened this issue Jul 9, 2018 · 2 comments

Comments

@jayvdb
Copy link
Member

jayvdb commented Jul 9, 2018

Most of the go linters are installed using gometalinter which keeps a versioned copy of the dependencies.

However we still have the manual install of

go get -u sourcegraph.com/sqs/goreturns
go get -u github.com/BurntSushi/toml/cmd/tomlv

tomlv isnt a linter of go language, so it wont be suitable for gometalinter, but it is less likely to break with go versions because it doesnt check go syntax which changes with each golang version and doesnt depend on golang syntax parsers which improves (aka breaks) with each golang version.

goreturns could be proposed to gometalinter, allowing us to maintain all go syntax linters via gometalinter

(See #2599 for removal of unnecessary go gets)

jayvdb added a commit to jayvdb/coala-bears that referenced this issue Jul 9, 2018
@jayvdb jayvdb added the upstream label Jul 9, 2018
jayvdb added a commit to jayvdb/coala-bears that referenced this issue Jul 9, 2018
jayvdb added a commit to jayvdb/coala-bears that referenced this issue Jul 9, 2018
@jayvdb
Copy link
Member Author

jayvdb commented Jul 9, 2018

Another go bear to potentially add to gometalinter #1649

jayvdb added a commit to jayvdb/coala-bears that referenced this issue Jul 16, 2018
gitmate-bot pushed a commit to jayvdb/coala-bears that referenced this issue Jul 16, 2018
@jayvdb
Copy link
Member Author

jayvdb commented Dec 15, 2018

goreturns proposed upstream at alecthomas/gometalinter#568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants